{{ message }}
refactor(docs-infra): validate api/cdk and api/aria links - #70586
Open
erkamyaman wants to merge 1 commit into
Open
refactor(docs-infra): validate api/cdk and api/aria links#70586erkamyaman wants to merge 1 commit into
erkamyaman wants to merge 1 commit into
Conversation
`isKnownRoute` exempted both families behind TODOs waiting on route extraction for those packages. That extraction had already landed when the TODOs were written in angular#66254: cdk pages since angular#60853 and aria pages since the cross-repo workflow. `defined-routes.json` carries 70 `api/cdk` and 39 `api/aria` routes today, and all 45 such link targets in the guides resolve, so the build stays green without the exemptions. The gap was not theoretical. `guide/aria/select.md` and `guide/aria/multiselect.md` linked `api/cdk/overlay/CdkConnectedOverlay`, which has never been a route, and it shipped as a 404 for six months. Link validation landed four months into that and said nothing, because of this exemption. It took a user filing angular#68914 and an outside contributor fixing it in angular#68915. Pointing an existing `api/cdk` link at a symbol that does not exist passes the build today and fails it with this change.
angular-robot
Bot
added
the
area: docs-infra
JeanMeche
approved these changes
Sep 6, 2026
JeanMeche
added
action: merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isKnownRouteexempted both families behind TODOs waiting on route extraction for those packages. That extraction had already landed when the TODOs were written in #66254: cdk pages since #60853 and aria pages since the cross-repo workflow.defined-routes.jsoncarries 70api/cdkand 39api/ariaroutes today, and all 45 such link targets in the guides resolve, so the build stays green without the exemptions.The gap was not theoretical.
guide/aria/select.mdandguide/aria/multiselect.mdlinkedapi/cdk/overlay/CdkConnectedOverlay, which has never been a route, and it shipped as a 404 for six months. Link validation landed four months into that and said nothing, because of this exemption. It took a user filing #68914 and an outside contributor fixing it in #68915.