docs(docs-infra): Throw build error on invalid guide links by JeanMeche · Pull Request #66254 · angular/angular · GitHub
Skip to content

docs(docs-infra): Throw build error on invalid guide links - #66254

Merged
thePunderWoman merged 2 commits into
angular:mainfrom
JeanMeche:docs/invalid-links
Jan 12, 2026
Merged

docs(docs-infra): Throw build error on invalid guide links#66254
thePunderWoman merged 2 commits into
angular:mainfrom
JeanMeche:docs/invalid-links

Conversation

@JeanMeche

@JeanMeche JeanMeche commented Dec 26, 2025

Copy link
Copy Markdown
Member

The list of valid links is generated from the guides configuration in the ADEV app.
Redirections are knowingly exclude so we stop referencing them.

This commit also fixes all necessary links.

This is to detect issues like #66246 at build time.

@angular-robot angular-robot Bot added area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure labels Dec 26, 2025
@ngbot ngbot Bot added this to the Backlog milestone Dec 26, 2025
@JeanMeche
JeanMeche force-pushed the docs/invalid-links branch 2 times, most recently from 7b3b854 to 96aa219 Compare December 26, 2025 12:07
@JeanMeche
JeanMeche marked this pull request as ready for review December 26, 2025 12:14
@JeanMeche
JeanMeche force-pushed the docs/invalid-links branch 3 times, most recently from 95f4404 to 23ae41a Compare December 28, 2025 13:27
@JeanMeche
JeanMeche force-pushed the docs/invalid-links branch 11 times, most recently from 2a1fabd to b025ea1 Compare January 4, 2026 01:18
Comment thread adev/shared-docs/pipeline/shared/marked/transformations/heading.mts Outdated
Comment thread adev/shared-docs/pipeline/shared/marked/renderer.mts
Comment thread adev/shared-docs/pipeline/shared/marked/renderer.mts Outdated
Comment thread adev/shared-docs/pipeline/guides/index.mts Outdated
Comment thread adev/shared-docs/pipeline/shared/marked/renderer.mts Outdated
Comment thread adev/shared-docs/pipeline/_guides.bzl Outdated
Comment thread adev/shared-docs/pipeline/_guides.bzl Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So now we have to maintain this document of routes as well? I just want to make sure I am understanding correctly

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's more like, this is now we file we need to update when we add routes. adev/src/app/routing/sub-navigation-data.ts is almost empty now

@JeanMeche
JeanMeche force-pushed the docs/invalid-links branch 3 times, most recently from 2ccff9a to a906268 Compare January 9, 2026 00:59
@JeanMeche
JeanMeche force-pushed the docs/invalid-links branch 3 times, most recently from 9d3231a to 6f01751 Compare January 9, 2026 03:13
Comment thread adev/scripts/routes/generate-routes.mts
Comment thread adev/shared-docs/pipeline/guides/index.mts Outdated
Comment thread adev/shared-docs/pipeline/shared/marked/transformations/heading.mts
Comment thread adev/BUILD.bazel Outdated
Comment thread adev/src/app/routing/navigation-entries/BUILD.bazel
@JeanMeche
JeanMeche force-pushed the docs/invalid-links branch 3 times, most recently from a374676 to 7bcbc63 Compare January 12, 2026 20:14
The list of valid links is generated from navigation data configuration in the ADEV app.
Redirections are knowingly exclude so we stop referencing them.

This commit also fixes all necessary links.

@josephperrott josephperrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed action: merge The PR is ready for merge by the caretaker labels Jan 12, 2026
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate and removed target: patch This PR is targeted for the next patch release labels Jan 12, 2026
@thePunderWoman
thePunderWoman merged commit c09f535 into angular:main Jan 12, 2026
22 checks passed
@thePunderWoman

Copy link
Copy Markdown
Contributor

This PR was merged into the repository. The changes were merged into the following branches:

@angular-automatic-lock-bot

Copy link
Copy Markdown

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Feb 12, 2026
@JeanMeche
JeanMeche deleted the docs/invalid-links branch April 12, 2026 19:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants