{{ message }}
fix(docs-infra): only read a deprecation version from the start of the tag - #70580
Open
erkamyaman wants to merge 1 commit into
Open
fix(docs-infra): only read a deprecation version from the start of the tag#70580erkamyaman wants to merge 1 commit into
erkamyaman wants to merge 1 commit into
Conversation
…e tag `getTagSinceVersion` matched `\d+(\.\d+)?` anywhere in the tag comment. That works for `@developerPreview`, `@experimental` and `@stable`, whose comment is only a version, but `@deprecated` also carries a message, so any number in the prose won. https://angular.dev/api/common/getLocaleCurrencyCode reads "deprecated since v4217", taken from "a map of locale to ISO 4217 currency codes", and eighteen sibling pages take v18 from the "i18n" in "relying on the `Intl` API for i18n". Anchoring the match, and allowing the `since`/`from`/`as of` prefixes the comments use, leaves all seventy-nine correctly versioned comments untouched. `generate_manifest` carries its own copy of the regex, so the API list badges had the same values. Those `@angular/common` comments never stated a version, so they now say `18.0` explicitly, the release `d34c033902` (angular#54483) first shipped in, matching the `@deprecated 18.0` already on `FormatWidth` in the same file. Nine tags in that file had no version at all and were showing no badge; they are from the same commit and now say `18.0` too.
angular-robot
Bot
added
the
area: docs-infra
JeanMeche
approved these changes
Sep 5, 2026
JeanMeche
left a comment
JeanMeche
left a comment
Member
There was a problem hiding this comment.
Wow to bad there isn't a v4217 😄😄
JeanMeche
added
the
merge: caretaker note
Member
JeanMeche
added
action: merge
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good news: angular.dev now ships a roadmap spoiler.
getLocaleCurrencyCodeis documented as "deprecated since v4217", which at our current pace of one major a year puts that release in the year 6221. I appreciate the long term commitment, but I suspect the docs got ahead of the RFC.The joke aside explanation is that the version is scraped with
\d+(\.\d+)?from anywhere in the@deprecatedcomment, and that comment says "create a map of locale to ISO 4217 currency codes."https://angular.dev/api/common/getLocaleCurrencyCode
After: