{{ message }}
refactor(common): Deprecate Local Data API functions - #54483
Closed
JeanMeche wants to merge 1 commit into
Closed
Conversation
JeanMeche
force-pushed
the
deprecate-locale-data
branch
from
February 16, 2024 14:29
60fa01b to
9af251a
Compare
JeanMeche
force-pushed
the
deprecate-locale-data
branch
4 times, most recently
from
February 16, 2024 23:52
0a4ae0a to
dbc85d3
Compare
angular-robot
Bot
added
the
detected: deprecation
JeanMeche
force-pushed
the
deprecate-locale-data
branch
2 times, most recently
from
February 17, 2024 02:28
7e9361c to
ee7bb12
Compare
JeanMeche
force-pushed
the
deprecate-locale-data
branch
2 times, most recently
from
February 28, 2024 19:22
3f12936 to
ce9f5e9
Compare
JeanMeche
marked this pull request as ready for review
February 29, 2024 22:28
JeanMeche
requested review from
devversion
and removed request for
atscott and
dgp1130
February 29, 2024 22:29
JeanMeche
added
action: review
pkozlowski-opensource
added
the
area: common
devversion
reviewed
Mar 7, 2024
Member
There was a problem hiding this comment.
Why is that? Can we provide more context to our users?
Member
Author
There was a problem hiding this comment.
I was under the impression that this was recommended but after further investigation I can see that several languages/frameworks also provide such data. I'll look for an alternative to suggest.
Member
Author
There was a problem hiding this comment.
There is no reputable js library that provides this feature nor does it seem that a tc39 proposal is in the pipe.
Let me know what you think the suggestion I added.
JeanMeche
force-pushed
the
deprecate-locale-data
branch
2 times, most recently
from
March 12, 2024 20:39
204c7ef to
e7bfe32
Compare
Ahead of delegating the i18n subsystem to the `Intl` API, this commit introduce the intention to remove those functions from the public API. DEPRECATED: `getCurrencySymbol`, `getLocaleCurrencyCode`, `getLocaleCurrencyName`, `getLocaleCurrencySymbol`, `getLocaleDateFormat`, `getLocaleDateTimeFormat`, `getLocaleDayNames`, `getLocaleDayPeriods`, `getLocaleDirection`, `getLocaleEraNames`, `getLocaleExtraDayPeriodRules`, `getLocaleExtraDayPeriods`, `getLocaleFirstDayOfWeek`, `getLocaleId`, `getLocaleMonthNames`, `getLocaleNumberFormat`, `getLocaleNumberSymbol`, `getLocalePluralCase`, `getLocaleTimeFormat`, `getLocaleWeekEndRange`, `getNumberOfCurrencyDigits`
JeanMeche
force-pushed
the
deprecate-locale-data
branch
from
April 10, 2024 14:55
e7bfe32 to
9b6cedd
Compare
AndrewKushnir
approved these changes
Apr 23, 2024
AndrewKushnir
left a comment
AndrewKushnir
left a comment
Contributor
There was a problem hiding this comment.
Reviewed-for: public-api
AndrewKushnir
added
action: merge
AndrewKushnir
approved these changes
Apr 23, 2024
Member
|
This PR was merged into the repository by commit d34c033. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ahead of delegating the i18n subsystem to the
IntlAPI, this commit introduces the intention to remove those functions from the public API.DEPRECATION:
getCurrencySymbol,getLocaleCurrencyCode,getLocaleCurrencyName,getLocaleCurrencySymbol,getLocaleDateFormat,getLocaleDateTimeFormat,getLocaleDayNames,getLocaleDayPeriods,getLocaleDirection,getLocaleEraNames,getLocaleExtraDayPeriodRules,getLocaleExtraDayPeriods,getLocaleFirstDayOfWeek,getLocaleId,getLocaleMonthNames,getLocaleNumberFormat,getLocaleNumberSymbol,getLocalePluralCase,getLocaleTimeFormat,getLocaleWeekEndRange,getNumberOfCurrencyDigits