{{ message }}
refactor(core): Add schematics to opt-out of theIntl based implemen… - #55355
Closed
JeanMeche wants to merge 1 commit into
Closed
refactor(core): Add schematics to opt-out of theIntl based implemen…#55355JeanMeche wants to merge 1 commit into
Intl based implemen…#55355JeanMeche wants to merge 1 commit into
Conversation
JeanMeche
force-pushed
the
intl-opt-out-migration
branch
3 times, most recently
from
April 16, 2024 22:29
595f2f9 to
008c7f5
Compare
Comment on lines
1
to
3
Contributor
There was a problem hiding this comment.
I'd propose rephrasing this more like retaining CLDR-based logic for existing applications.
JeanMeche
force-pushed
the
intl-opt-out-migration
branch
from
April 17, 2024 18:44
008c7f5 to
b420e44
Compare
JeanMeche
marked this pull request as ready for review
April 17, 2024 18:44
…tation for Date formatting This migration schematics aims to migrate every existing app, to opt-out of the new `Intl` based implementation to smooth out the transition to the new implementation. A TODO is added to invite developers to try-out themselves the new implementation.
JeanMeche
force-pushed
the
intl-opt-out-migration
branch
from
April 17, 2024 18:53
b420e44 to
39f1297
Compare
Member
Author
|
Note: We had to change strategy, opt-out is too breaking for G3. We'll go with an opt-in in an upcoming minor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tation for Date formatting
#55283 introduced an Intl implementation for the i18n sub-system. For dates, the change might be considered breaking.
This migration schematics aims to migrate every existing app, to opt-out of the new
Intlbased implementation to smooth out the transition to the new implementation.A TODO is added to invite developers to try-out themselves the new implementation.