feat(common): Add an`Intl` implementation for the i18n sub-system. by JeanMeche · Pull Request #55283 · angular/angular · GitHub
Skip to content

feat(common): Add anIntl implementation for the i18n sub-system. - #55283

Closed
JeanMeche wants to merge 6 commits into
angular:mainfrom
JeanMeche:poc-intl-date
Closed

feat(common): Add anIntl implementation for the i18n sub-system. #55283
JeanMeche wants to merge 6 commits into
angular:mainfrom
JeanMeche:poc-intl-date

Conversation

@JeanMeche

@JeanMeche JeanMeche commented Apr 10, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Angular's i18n subsystem is responsible for providing localised formatting of numbers, percents, percentages and dates.
This feature replaces the default implementation of the i18N subsystem.

The commits add a new implementation that relies on the platform-provided Intl API.

With this new implementation relying on a platform API, it is not necessary anymore the load locale files (See #20487) .

The new implementation is available via an opt-in : useIntlImplementation().

This feature fixes the following issues:

Closes #54470

@angular-robot angular-robot Bot added the detected: feature PR contains a feature commit label Apr 10, 2024
@JeanMeche
JeanMeche force-pushed the poc-intl-date branch 2 times, most recently from 6c939c3 to 0ceb875 Compare April 10, 2024 15:02
@angular-robot angular-robot Bot added the detected: deprecation PR contains a commit with a deprecation label Apr 10, 2024
@JeanMeche JeanMeche changed the title feat(common): Add support for i18N using the Intl API feat(common): Add and enable the Intl implementation for the i18n sub-system. Apr 10, 2024
alan-agius4
alan-agius4 reviewed Apr 10, 2024
View reviewed changes
Comment thread packages/core/src/i18n/locale_data_api.ts Outdated
@JeanMeche JeanMeche changed the title feat(common): Add and enable the Intl implementation for the i18n sub-system. feat(common): Add and enable the Intl implementation for the i18n sub-system. Apr 10, 2024
@JeanMeche JeanMeche added feature Label used to distinguish feature request from other issues breaking changes area: i18n Issues related to localization and internationalization and removed detected: feature PR contains a feature commit labels Apr 11, 2024
@ngbot ngbot Bot added this to the Backlog milestone Apr 11, 2024
@JeanMeche JeanMeche added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 11, 2024
@angular-robot angular-robot Bot added the detected: feature PR contains a feature commit label Apr 11, 2024
@alxhub alxhub self-assigned this Apr 11, 2024
@angular-robot angular-robot Bot added the detected: breaking change PR contains a commit with a breaking change label Apr 12, 2024
@JeanMeche
JeanMeche force-pushed the poc-intl-date branch 2 times, most recently from 767753e to 1ca64d6 Compare April 12, 2024 10:27
@JeanMeche
JeanMeche marked this pull request as ready for review April 12, 2024 10:42
@pullapprove
pullapprove Bot requested review from AndrewKushnir and atscott April 12, 2024 10:42
@JeanMeche JeanMeche mentioned this pull request Apr 16, 2024
Closed
@angular-robot angular-robot Bot removed the detected: breaking change PR contains a commit with a breaking change label Apr 18, 2024
@JeanMeche
JeanMeche force-pushed the poc-intl-date branch 11 times, most recently from e9dd865 to 841fe08 Compare April 22, 2024 15:28
@JeanMeche JeanMeche mentioned this pull request Apr 25, 2024
Closed
devversion
devversion reviewed May 3, 2024
View reviewed changes

@devversion devversion left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of currency formatting + plural

Comment thread packages/common/test/pipes/number_pipe_spec.ts Outdated

@devversion devversion May 3, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a follow-up to remove this?

@JeanMeche JeanMeche May 5, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix the formatting once the PR is merge.

Comment thread packages/common/src/i18n/format_number.ts Outdated
Comment thread packages/common/src/i18n/format_number.ts Outdated
Comment thread goldens/public-api/common/index.md Outdated
Comment thread packages/common/test/i18n/format_number_spec.ts Outdated
Comment thread packages/common/src/i18n/intl_helpers.ts Outdated
Comment thread packages/common/src/i18n/intl_helpers.ts Outdated
Comment thread packages/common/src/i18n/intl_helpers.ts Outdated
Comment thread packages/common/src/i18n/intl_helpers.ts Outdated
Comment thread packages/core/src/i18n/locale_data_api.ts Outdated

@devversion devversion May 3, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a breaking change? i.e. there isn't even a way to get back to legacy CLDR here AFAICT

@JeanMeche JeanMeche May 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TGP returned green for this.

Here is the support form Intl.PluralRules.supportedLocalesOf, it is widely within the scope of our supported browser versions.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/PluralRules/supportedLocalesOf

Depending on how strict we are on our breaking change policy, I can be considered breaking or non-breaking. Happy to know what you (and others) think about this.

@devversion devversion May 7, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Google3 actually use the CLDR plural data? I don't know off hand.

@JeanMeche JeanMeche May 24, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed my mind on this. Let's stay on the safe side and make plural also opt-in.

@JeanMeche JeanMeche mentioned this pull request May 24, 2024
Open
@JeanMeche JeanMeche mentioned this pull request Jun 3, 2024
Closed
3 tasks
@JeanMeche JeanMeche mentioned this pull request Jul 9, 2024
Closed
@JeanMeche JeanMeche mentioned this pull request Jul 30, 2024
Closed
@JeanMeche JeanMeche mentioned this pull request Sep 22, 2024
Closed
@csvn

csvn commented May 16, 2025

Copy link
Copy Markdown
Contributor

I hope I'm not being a nuisance, but what is the status for this PR? I see it was removed from v20 milestone recently, and the last thing mentioned was in #57916:

I hope that we can ship it with v19, mid November.

  • Since using Intl is opt-in, can't this land in a minor version?
  • I looked through tests and code a bit, is there any work left for this to be "done"?

I've been considering replacing @angular/common in our application with pipes/helpers based on Intl so we can format based on the users current locale instead, which is a lot messier when registerLocaleData() is required to use. I thought we'd wait perhaps for this PR to land though, to avoid building something custom if it will be supported in Angular. 😅

@PowerKiKi

PowerKiKi commented Jun 2, 2025

Copy link
Copy Markdown
Contributor

I was sure this PR was merged and released already. So I was rather confused when I tried to use intl implementation, but couldn't find anything about it in current Angular source code.

I too would appreciate using this new, lighter, way to do format things. Anything we can do to help move it forward ?

JeanMeche added 6 commits June 10, 2025 10:31
@JeanMeche
feat(common): add Intl implementation to format numbers, percents a…
64f5d52 
…nd currencies

This commit adds an `Intl` implementation to format numbers, percents and currencies.
The implementation is based on the `Intl` API and allows to drop the static imports for the locale date files.

fixes angular#33803
@JeanMeche
feat(common): use the Intl API to for plurals
a3cd938 
With this commit, plurals formatting does not depend on the CLDR locale data anymore.
@JeanMeche
feat(common): add an Intl API implementation for date formatting.
8320091 
With this commit, the Intl implementation because the default one and doesn't require the CLDR locale data imports anymore.

Opt-out is possible by invoking `useLegacyDateFormatting()` ahead of bootstrap.

BREAKING CHANGE: Some custom date format aren't supported any more (`cccccc`, `EEEEEE`, `aaaaa`, `b` to `bbbbb` and `B` to `BBBBB`)
The `DatePipe` will not support offset timezone anymore, use IANA timezones instead .
@JeanMeche
fixup! feat(common): add Intl implementation to format numbers, per…
cfab118 
…cents and currencies
@JeanMeche
fixup! feat(common): use the Intl API to for plurals
221bf34
@JeanMeche
fixup! feat(common): add an Intl API implementation for date format…
9987de8 
…ting.
@mauriziocescon

mauriziocescon commented Aug 27, 2025

Copy link
Copy Markdown

I wonder: any hope for v21 or no way?

@eneajaho eneajaho mentioned this pull request Sep 4, 2025
Open
@angular-robot

angular-robot Bot commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

This draft PR is being closed because it has been stale for 28 days and has seen no activity from you. If you'd like to see this change land, you can re-open this PR. Thank you for being an Angular contributor!

@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented May 18, 2026

Copy link
Copy Markdown

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion left review comments
@alan-agius4 alan-agius4 alan-agius4 left review comments
@AndrewKushnir AndrewKushnir Awaiting requested review from AndrewKushnir

Assignees

@alxhub alxhub

@AndrewKushnir AndrewKushnir

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer area: common Issues related to APIs in the @angular/common package area: i18n Issues related to localization and internationalization detected: breaking change PR contains a commit with a breaking change detected: feature PR contains a feature commit feature Label used to distinguish feature request from other issues target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

Use platform Intl APIs in Angular's i18n subsystem

8 participants

@JeanMeche @AndrewKushnir @csvn @PowerKiKi @mauriziocescon @devversion @alan-agius4 @alxhub