packages\upgrade\static\src symlink doesn't work on Windows · Issue #16760 · angular/angular · GitHub
Skip to content

packages\upgrade\static\src symlink doesn't work on Windows #16760

Description

@bisubus

I'm submitting a ... (check one with "x")

[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior

packages\upgrade\static\src is a symbolic link that isn't interpreted correctly on Windows. This results in error during compilation:

Compiling tools...
Creating .metadata.json files...
Error: Error at <...>/packages/upgrade/static/public_api.ts:15:44: Cannot find module './src/common/angular1'.
Error at <...>/packages/upgrade/static/public_api.ts:16:34: Cannot find module './src/common/downgrade_component'.
Error at <...>/packages/upgrade/static/public_api.ts:17:35: Cannot find module './src/common/downgrade_injectable'.
Error at <...>/packages/upgrade/static/public_api.ts:18:23: Cannot find module './src/common/version'.
Error at <...>/packages/upgrade/static/public_api.ts:19:32: Cannot find module './src/static/upgrade_component'.
Error at <...>/packages/upgrade/static/public_api.ts:20:29: Cannot find module './src/static/upgrade_module'.
    at UserError.Error (native)
    at new UserError (<...>\dist\tools\@angular\tsc-wrapped\src\tsc.js:21:28)
    at check (<...>\dist\tools\@angular\tsc-wrapped\src\tsc.js:87:15)
    at Tsc.typeCheck (<...>\dist\tools\@angular\tsc-wrapped\src\tsc.js:172:9)
    at <...>\dist\tools\@angular\tsc-wrapped\src\main.js:106:23
    at process._tickCallback (internal/process/next_tick.js:109:7)
    at Module.runMain (module.js:606:11)
    at run (bootstrap_node.js:390:7)
    at startup (bootstrap_node.js:150:9)
    at bootstrap_node.js:505:3
Compilation failed

Expected behavior

Symbolic link is supposed to work for all operation systems.

Minimal reproduction of the problem with instructions

In cloned repo:

npm i
bash ./scripts/windows/create-symlinks.sh
bash ./test.sh node

Please tell us about your environment:

Windows 7
Node 6.10.3
NPM 3.10.10
git 2.9.0.windows.1

  • Angular version: 4.2.0-beta.1

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: build & ciRelated the build and CI infrastructure of the project

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions