build: update Windows symlink scripts by bisubus · Pull Request #16761 · angular/angular · GitHub
Skip to content

build: update Windows symlink scripts - #16761

Merged
vicb merged 1 commit into
angular:masterfrom
bisubus:fix-windows-symlinks-2
Nov 2, 2017
Merged

vicb merged 1 commit into
angular:masterfrom
bisubus:fix-windows-symlinks-2

Conversation

@bisubus

@bisubus bisubus commented May 12, 2017

Copy link
Copy Markdown

Fixes packages\upgrade\static\src symlink.

Closes #16760

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

See #16760

What is the new behavior?

packages\upgrade\static\src symbolic link behaves as expected on Windows.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@bisubus bisubus changed the title fix(build): update Windows symlink scripts build: update Windows symlink scripts May 12, 2017
@bisubus
bisubus force-pushed the fix-windows-symlinks-2 branch from eca464b to 1d85267 Compare May 12, 2017 17:58
@jasonaden jasonaden added the area: build & ci Related the build and CI infrastructure of the project label May 15, 2017
@jasonaden
jasonaden requested review from jasonaden and mhevery and removed request for jasonaden May 15, 2017 18:20
@gkalpak

gkalpak commented Jul 4, 2017

Copy link
Copy Markdown
Member

Fixes packages\upgrade\static\src symlink.

Closes angular#16760
@mhevery
mhevery force-pushed the fix-windows-symlinks-2 branch from 1d85267 to e1876d8 Compare July 26, 2017 19:50
@gkalpak gkalpak added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Sep 18, 2017
@gkalpak

gkalpak commented Sep 18, 2017

Copy link
Copy Markdown
Member

/ping @mhevery, @IgorMinar

@mhevery mhevery added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 24, 2017
@vicb
vicb merged commit 613a9e3 into angular:master Nov 2, 2017
vicb pushed a commit that referenced this pull request Nov 2, 2017
Fixes packages\upgrade\static\src symlink.

Closes #16760
@gkalpak

gkalpak commented Nov 3, 2017

Copy link
Copy Markdown
Member

🎉

@angular-automatic-lock-bot

Copy link
Copy Markdown

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

packages\upgrade\static\src symlink doesn't work on Windows

6 participants