[22.1][Built-in] Moving WS view direction from vertex to fragment to lower varying size by skerys · Pull Request #6542 · Unity-Technologies/Graphics · GitHub
Skip to content

[22.1][Built-in] Moving WS view direction from vertex to fragment to lower varying size#6542

Merged
sebastienlagarde merged 1 commit into
2022.1/stagingfrom
2022.1/shadergraph/builtin-world-space-view-dir-to-frag
Dec 13, 2021
Merged

[22.1][Built-in] Moving WS view direction from vertex to fragment to lower varying size#6542
sebastienlagarde merged 1 commit into
2022.1/stagingfrom
2022.1/shadergraph/builtin-world-space-view-dir-to-frag

Conversation

@skerys

@skerys skerys commented Dec 9, 2021

Copy link
Copy Markdown
Contributor

Purpose of this PR

Backport of #6512


Testing status

tested the BuiltinGraphicsTest_Lighting project locally
PR Shadergraph + ShaderGraph_BuiltIn_Lighting in yamato

@github-actions

github-actions Bot commented Dec 9, 2021

Copy link
Copy Markdown

@peterjohnlong

Copy link
Copy Markdown
Contributor

Sorry I accidently added backport labels to the wrong PR, I removed them again. Sorry!

@skerys skerys marked this pull request as ready for review December 9, 2021 16:15
@skerys skerys requested a review from a team as a code owner December 9, 2021 16:15

@jessebarker jessebarker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skerys

skerys commented Dec 10, 2021

Copy link
Copy Markdown
Contributor Author

@sebastienlagarde sebastienlagarde merged commit 76bb39b into 2022.1/staging Dec 13, 2021
@sebastienlagarde sebastienlagarde deleted the 2022.1/shadergraph/builtin-world-space-view-dir-to-frag branch December 13, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants