{{ message }}
[Built-in] Moving WS view direction from vertex to fragment to lower varying size#6512
Merged
sebastienlagarde merged 1 commit intoDec 8, 2021
Conversation
phi-lira
approved these changes
Dec 7, 2021
Contributor
Author
|
The two test failures in |
joshua-davis
approved these changes
Dec 7, 2021
sebastienlagarde
deleted the
shadergraph/builtin-world-space-view-dir-to-frag
branch
Contributor
|
Does this need to be backport to 22.1? / 21.2? I see the original PR is from September |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Removing WS view direction from varyings broke shadergraph on built-in renderer. This PR makes built-in mirror the new behavior in URP (added with #5509), by moving the calculation of WS view direction into fragment shader.
Testing status
tested the BuiltinGraphicsTest_Lighting project locally
checked the behavior of the View Direction node
PR Shadergraph + ShaderGraph_BuiltIn_Lighting in yamato