{{ message }}
Conversation
theopnv
approved these changes
Nov 25, 2021
theopnv
left a comment
theopnv
left a comment
Contributor
There was a problem hiding this comment.
LGTM, let's wait for the tests results.
Contributor
Author
theopnv
approved these changes
Dec 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Quick PR to copy the project using rsync to remote macOS devices to improve resilience. Unlike #6286 we're not attempting to skip any files or folders (as some tools might assume the existence of those). Note that compression (
-z) led to a walltime penalty in our scenarios (see ticket for more details) so it is not enabled. The ticket also contains a quick summary of why the specific flags are used. The goal of this PR is to increase resilience in case of brief network hiccups (we still want to fail the pipeline if network issues persist).