{{ message }}
Conversation
theopnv
reviewed
Nov 16, 2021
Contributor
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Small PR to copy the project using rsync to remote macOS devices to improve stability and reduce walltime.
The two main benefits are increased resilience (especially in regards to retries) and skipping
.files/folders.Quick note:
rsynccan compress files for transfer (-z, trading cpu utilization and network bandwidth) which led to a walltime penalty in our scenarios (see ticket for more details) so it is not part of the PR.Draft PR with more pipelines to be scheduled, for success we should not see regressions in walltime and all further steps should find their required files in the same location (we should not see any pipeline failures related to this change). See ant-276.