{{ message }}
[7.x.x] Removal of Graphics Test Framework#474
Closed
sophiaaar wants to merge 46 commits into
Closed
Conversation
Contributor
DennisDeRykeUnity
approved these changes
May 15, 2020
DennisDeRykeUnity
left a comment
DennisDeRykeUnity
left a comment
Contributor
There was a problem hiding this comment.
Approving -- see my previous comment regarding the changesets I added and Yamato jobs in progress.
…ode only, since Standalone passed for these two tests on Yamato.
Contributor
|
@sophiaaar I fixed tests 018 and 019 in commit 8cfd398. When you merge this PR, would you be willing to merge commit 8cfd398 which re-enables most of the tests that you originally disabled, and is green on Yamato here: |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Backport of #32
Testing status
Manual Tests
Ran the project to ensure no errors occurred, but can't test fully on my Mac
Links
Yamato:
https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics/tree/7.x.x%252Fbackport%252Ftesting%252Fgtf-removal
Comments to reviewers
Also disable tests 011, 017, 018, 019, 020, 021, 022 - fogbugz case will be made so these issues can be followed up on