{{ message }}
[7.x.x] Backport test filters#448
Closed
tomzig16 wants to merge 4 commits into
Closed
Conversation
sophiaaar
approved these changes
May 14, 2020
sophiaaar
left a comment
sophiaaar
left a comment
Contributor
There was a problem hiding this comment.
I'm fine to approve this as it is needed, but this may end up getting overwritten when my backport for the graphics test framework update lands
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Filters were added to the master branch in commit d26e9d1, together with Android support. However, as now I am more focused in making iOS run and have been blocked a bit on Android backport I decided to push PR for filters alone for now.
Testing status
Manual Tests
Locally tested if filters out (tested on OSX platform)
Automated Tests
Tested yamato with several configurations (DX11 playmode)
Links
Yamato: https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics/tree/7.x%252Fbackport%252Ffilters
Comments to reviewers
This PR does not change any tests themselves.