{{ message }}
test: prove fine-grained external-repo hashing is hermetic across wor…#387
Merged
tinder-maxwellelliott merged 1 commit intoJun 25, 2026
Conversation
…kspaces Adds an E2E test that runs generate-hashes with --fineGrainedHashExternalRepos on the same wrapped_external_repo fixture checked out at two different absolute paths (each with its own Bazel output base, as on two CI agents) and asserts the fine-grained target hashes are identical. This covers the fine-grained path specifically: @inner_repo's individual targets are hashed, including the source file @inner_repo//:data.txt which flows through SourceFileHasher (the path made portable in Tinder#385). The synthetic //external:* blob targets are excluded from the comparison -- they are a separate, non-fine-grained representation and, for local_path_override repos, can carry an absolute machine-specific `path` attribute (tracked separately). Gated to Bazel 8.6.0+/9.0.1+ to match the other bzlmod E2E tests; CI runs Bazel 8.x/9.x so it executes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FLwXzgBTGkZp63N9jv16x8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…kspaces
Adds an E2E test that runs generate-hashes with --fineGrainedHashExternalRepos on the same wrapped_external_repo fixture checked out at two different absolute paths (each with its own Bazel output base, as on two CI agents) and asserts the fine-grained target hashes are identical.
This covers the fine-grained path specifically: @inner_repo's individual targets are hashed, including the source file @inner_repo//:data.txt which flows through SourceFileHasher (the path made portable in #385). The synthetic //external:* blob targets are excluded from the comparison -- they are a separate, non-fine-grained representation and, for local_path_override repos, can carry an absolute machine-specific
pathattribute (tracked separately).Gated to Bazel 8.6.0+/9.0.1+ to match the other bzlmod E2E tests; CI runs Bazel 8.x/9.x so it executes.