{{ message }}
fix: use workspace-stable content-hash key for external repo source f…#385
Merged
tinder-maxwellelliott merged 1 commit intoJun 24, 2026
Conversation
…iles Source file digests are already content-based and path-independent, but the content-hash-provider lookup key for fine-grained external repo files was the absolute path under the Bazel output base (e.g. /var/lib/buildkite-agent/builds/.../external/<repo>/...). That path embeds machine/instance-specific components, so a --contentHashPath map generated on one machine could never match external-repo entries on another, defeating the cross-machine cache and reintroducing non-determinism for any rule depending on those source files. Use a workspace-stable key (external/<repoName>/<relativePath>) for the content-hash lookup while still resolving the absolute path solely to read the file from disk. Main-repo keys are unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FLwXzgBTGkZp63N9jv16x8
This was referenced Jun 24, 2026
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…iles
Source file digests are already content-based and path-independent, but the content-hash-provider lookup key for fine-grained external repo files was the absolute path under the Bazel output base (e.g.
/var/lib/buildkite-agent/builds/.../external//...). That path embeds machine/instance-specific components, so a --contentHashPath map generated on one machine could never match external-repo entries on another, defeating the cross-machine cache and reintroducing non-determinism for any rule depending on those source files.
Use a workspace-stable key (external//) for the content-hash lookup while still resolving the absolute path solely to read the file from disk. Main-repo keys are unchanged.