{{ message }}
Repository navigation
fix: remove the intent bin that shadows @tanstack/intent - #542
Open
AlemTuzlak wants to merge 1 commit into
Open
AlemTuzlak wants to merge 1 commit into
AlemTuzlak wants to merge 1 commit into
Conversation
Five published packages declared `"bin": { "intent": "./bin/intent.js" }`.
npm can link that file as node_modules/.bin/intent instead of the real
@tanstack/intent CLI. The file imports @tanstack/intent/intent-library,
which @tanstack/intent removed (TanStack/intent#143), so `intent` failed with
ERR_PACKAGE_PATH_NOT_EXPORTED.
Current @tanstack/intent finds packages with skills by the
"tanstack-intent" keyword, so the packages get that keyword instead.
Fixes #525
|
View your CI Pipeline Execution ↗ for commit 841d43c
☁️ Nx Cloud last updated this comment at |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installing
@tanstack/devtoolsnext to@tanstack/intentcan makenode_modules/.bin/intentpoint to our bin, andintentthen fails withERR_PACKAGE_PATH_NOT_EXPORTED. This PR removes theintentbin from all packages. It adds thetanstack-intentkeyword, which current@tanstack/intentuses to find package skills.🎯 Changes
"bin": { "intent": "./bin/intent.js" }:devtools,devtools-utils,devtools-vite,devtools-webmcp, anddevtools-event-client. Each bin imports@tanstack/intent/intent-library.@tanstack/intentremoved that subpath and the bin-based discovery (Remove the abandoned intent-library bin intent#143). Because both packages declare anintentbin, npm can link either one.bin/intent.jsfiles (5 packages and the private root), thebinfields, thebinentries infiles, and the knip ignore for them.tanstack-intentkeyword.intent setupadds this keyword, andintent validatewarns when it is missing.✅ Checklist
pnpm test:pr, or these tests do not apply to this pull request.🚀 Release Impact
Testing
Commands run
publint --strictfordevtools,devtools-vite, anddevtools-event-client: all good.@tanstack/intent@0.5.0source: discovery uses thetanstack-intentkeyword, and the package exports only.and./core.pnpm test:pr.Manual test
intentbin conflicts with @tanstack/intent and imports removed subpath #525: a project with@tanstack/intentand@tanstack/devtools.npm cican link our bin, andnpx intent helpfails withERR_PACKAGE_PATH_NOT_EXPORTED.node_modules/.bin/intentis the@tanstack/intentCLI, andnpx @tanstack/intent listshows the devtools skills.How this PR makes testing easy
No new tests. This is a package metadata change, and
publintcovers the package shape.Linked issues
Fixes #525
Risk / rollback
Low. A user who ran our
intentbin directly loses it, but that bin already failed with current@tanstack/intent. To undo, revert this PR.Public API change
Before
npx intent list # can resolve to the bin from @tanstack/devtools, which throwsAfter
npx @tanstack/intent list # finds the devtools skills by the tanstack-intent keyword🤖 Generated with Claude Code