{{ message }}
fix(store): dont fail to load store if a single plugin is misconfigured#409
Merged
Merged
Conversation
ImDevinC
force-pushed
the
dont-fail-manifest
branch
from
f6a3b86 to
7e664ed
Compare
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if a plugin has a misconfigured manifest or if someone provides an invalid custom repository that is invalid,
the entire store will fail to load and will continue to load indefinitely. This change makes sure that if there is no
valid manifest for a plugin, we just skip it and continue on to the next plugin in the list.