fix(nodes): refuse link-local and cloud metadata targets in FetchNode by Arthur031221 · Pull Request #1173 · ScrapeGraphAI/Scrapegraph-ai · GitHub
Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions scrapegraphai/docloaders/chromium.py
15 changes: 12 additions & 3 deletions scrapegraphai/nodes/fetch_node.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
from ..docloaders import ChromiumLoader
from ..utils.cleanup_html import cleanup_html
from ..utils.convert_to_md import convert_to_md
from ..utils.url_safety import validate_redirect, validate_url
from .base_node import BaseNode


Expand Down Expand Up @@ -276,17 +277,25 @@ def handle_web_source(self, state, source):
dict: The updated state with the processed content.

Raises:
ValueError: If the fetched HTML content is empty or contains only whitespace.
ValueError: If the fetched HTML content is empty or contains only whitespace,
or if the URL points to a link-local or cloud metadata address.
"""

if not (self.browser_base or self.scrape_do):
validate_url(source)

self.logger.info(f"--- (Fetching HTML from: {source}) ---")
if self.use_soup:
# Apply configured timeout to blocking HTTP requests. If timeout is None,
# don't pass the timeout argument (requests will block until completion).
if self.timeout is None:
response = requests.get(source)
response = requests.get(source, hooks={"response": validate_redirect})
else:
response = requests.get(source, timeout=self.timeout)
response = requests.get(
source,
timeout=self.timeout,
hooks={"response": validate_redirect},
)
if response.status_code == 200:
if not response.text.strip():
raise ValueError("No HTML body content found in the response.")
Expand Down
61 changes: 61 additions & 0 deletions scrapegraphai/utils/url_safety.py
Loading