{{ message }}
Repository navigation
fix(nodes): refuse link-local and cloud metadata targets in FetchNode - #1173
Open
Arthur031221 wants to merge 1 commit into
Open
Arthur031221 wants to merge 1 commit into
Arthur031221 wants to merge 1 commit into
Conversation
Signed-off-by: Arthur031221 <levi74108520963@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1115
A service that passes user-supplied URLs to a graph can be pointed at cloud metadata endpoints like
http://169.254.169.254/latest/meta-data/.FetchNodegave the source straight torequestsor the browser.The new
utils/url_safety.pyresolves the host and raisesValueErrorfor link-local addresses (including IPv4-mapped, zone id, decimal and hex spellings) and known metadata addresses.FetchNodechecks the source before fetching, except on the BrowserBase and Scrape.do paths.use_soupalso checks redirect targets. The Playwright loaders abort requests to such hosts and check the page URL after load and after reading content. Selenium, DNS rebinding and service workers aren't covered.Loopback and private ranges stay allowed because local scraping relies on them. Link-local has no opt-out.
Tested with
pytest tests/utils/test_url_safety.py. TheChromiumLoadertest doubles gainedrouteandurl. Other lint and test failures already exist on pre/beta.Assisted by Claude/Codex.