iframe-proxy

dougfabris · 2026-10-20T19:59:18Z

Proposed changes (including videos or screenshots)

Since #42510, hovering a user mention opens the user card, but the mention still has its native title ("Mentions user" / "Mentions you"). The browser tooltip shows up at about the same time as the card and covers it. #42510 removed the native tooltip from the message author's avatar and name for the same reason, but not from mentions.

This removes the mention's title. Only GazzodownText provides resolveUserMention, and it also provides the hover handler, so every resolved mention opens the card. An unresolved mention renders as plain text and never had a title. @all and @here keep their titles.

Mentions_user was only used by that title, so it's removed from every locale. Mentions_you stays, because the thread unread badge still uses it.

Issue(s)

Regression from #42510 (not released yet).

CORE-2823

Steps to test or reproduce

Hover a user mention in a message: the user card opens and no browser tooltip appears.
Hover @all or @here: the tooltip still shows.

🤖 Generated with Claude Code

Summary by CodeRabbit

Bug Fixes
- Removed the hover tooltip from resolved user mentions.
- User mention labels, rendering, click behavior, hover behavior, and styling remain unchanged.
Localization
- Removed an unused user-mention translation entry from supported locales.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

dionisio-bot · 2026-10-20T19:59:24Z

changeset-bot · 2026-10-20T19:59:27Z

⚠️ No Changeset found

Latest commit: 11b2f5a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Every resolved mention opens the user card on hover, so the fallback that kept the tooltip never ran. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

cubic-dev-ai

All reported issues were addressed across 2 files

_{Reply with feedback, questions, or to request a fix.

View guided diff | Re-trigger cubic}

coderabbitai · 2026-10-20T20:02:11Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 62a4bfdd-db4c-4c6d-8990-095ddc5309ce

📥 Commits

Reviewing files that changed from the base of the PR and between cf3a6db and 11b2f5a.

📒 Files selected for processing: 2

apps/meteor/tests/e2e/user-card-info-actions-by-member.spec.ts
apps/meteor/tests/e2e/user-card-info-actions-by-room-owner.spec.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📜 Recent review details

⏰ Context from checks skipped due to timeout: 4

GitHub Check: ⚙️ Test Guard
GitHub Check: ⚙️ Variables Setup
GitHub Check: CodeQL-Build
GitHub Check: CodeQL-Build

🔇 Additional comments: 2

apps/meteor/tests/e2e/user-card-info-actions-by-member.spec.ts: 1

31-31: LGTM!

Also applies to: 62-62

apps/meteor/tests/e2e/user-card-info-actions-by-room-owner.spec.ts: 1

57-57: LGTM!

Also applies to: 70-70

Walkthrough

The user mention component no longer sets a conditional tooltip title. Eight locale catalogs no longer contain Mentions_user. User-card end-to-end tests now locate mentions by user ID through data-uid.

Changes

User Mention Tooltip

Layer / File(s)	Summary
Remove mention tooltip and translation entries `packages/gazzodown/src/mentions/UserMentionElement.tsx`, `packages/i18n/src/locales/*.i18n.json`	The component no longer sets the conditional title for user mentions. The `Mentions_user` entry was removed from eight locale catalogs.
Update mention selectors `apps/meteor/tests/e2e/user-card-info-actions-by-member.spec.ts`, `apps/meteor/tests/e2e/user-card-info-actions-by-room-owner.spec.ts`	The tests locate mentioned users by their IDs in the `data-uid` attribute. Member and non-member action expectations remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested labels: type: bug

Suggested reviewers: gabriellsh

Merge Risk: ⚪ Minimal · up to 11b2f

The tooltip removal preserves user-card hover behavior while retaining special mention tooltips.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly describes the main regression: a user mention tooltip covers the user card during hover. It is concise and specific.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files.

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Errors were encountered while retrieving linked issues.

Errors: 1

JIRA integration encountered authorization issues. Please disconnect and reconnect the integration in the CodeRabbit UI.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

✨ Finishing Touches: 💡 1

🛠️ Fix failing CI checks: 💡

Commit to this branch
Create a new PR

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

cubic-dev-ai

No issues found across 2 files

_{View guided diff | Re-trigger cubic}

cubic-dev-ai

All reported issues were addressed across 9 files (changes from recent commits).

_{Reply with feedback, questions, or to request a fix.

View guided diff | Re-trigger cubic}

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

codecov · 2026-10-20T20:32:52Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.98%. Comparing base (ccdf32b) to head (11b2f5a).
⚠️ Report is 47 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #42970   +/-   ##
========================================
  Coverage    70.98%   70.98%           
========================================
  Files         5426     5426           
  Lines       231655   231654    -1     
  Branches     42283    42196   -87     
========================================
+ Hits        164431   164441   +10     
+ Misses       61905    61898    -7     
+ Partials      5319     5315    -4

Flag	Coverage Δ
e2e	`58.94% <ø> (-0.04%)`	⬇️
e2e-api	`45.99% <ø> (-0.03%)`	⬇️
unit	`71.51% <ø> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

rc-layne · 2026-10-20T21:46:03Z

regression: user mention tooltip covers the user card on hover

2141c9c

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

dougfabris added this to the 8.10.0 milestone Oct 20, 2026

regression: drop the user mention tooltip outright

98257e1

Every resolved mention opens the user card on hover, so the fallback that kept the tooltip never ran. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

cubic-dev-ai Bot reviewed Oct 20, 2026

View reviewed changes

Comment thread packages/gazzodown/src/mentions/UserMentionElement.spec.tsx Outdated

regression: remove the unused Mentions_user key and the mention spec

cf3a6db

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

cubic-dev-ai Bot reviewed Oct 20, 2026

View reviewed changes

coderabbitai Bot added the type: bug label Oct 20, 2026

cubic-dev-ai Bot reviewed Oct 20, 2026

View reviewed changes

Comment thread packages/i18n/src/locales/en.i18n.json

test: locate user mentions by data-uid in the user card e2e specs

11b2f5a

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

dougfabris requested a review from a team as a code owner October 20, 2026 20:10

gabriellsh approved these changes Oct 20, 2026

View reviewed changes

jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Oct 21, 2026

Sunbelt Computer Software

PL/B Language Development and Support

Navigation Menu

Repository navigation

regression: user mention tooltip covers the user card on hover - #42970

regression: user mention tooltip covers the user card on hover#42970
dougfabris wants to merge 4 commits into
developfrom
regression/user-mention-tooltip-over-card

dougfabris commented Oct 20, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

dionisio-bot Bot commented Oct 20, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Oct 20, 2026 •

edited

Loading

Uh oh!

cubic-dev-ai Bot left a comment •

edited

Loading

Uh oh!

Uh oh!

coderabbitai Bot commented Oct 20, 2026 •

edited

Loading

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

cubic-dev-ai Bot left a comment •

edited

Loading

Uh oh!

Uh oh!

codecov Bot commented Oct 20, 2026 •

edited

Loading

Uh oh!

rc-layne Bot commented Oct 20, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Sunbelt Computer Software

PL/B Language Development and Support

Conversation

dougfabris commented Oct 20, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Summary by CodeRabbit

Uh oh!

dionisio-bot Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

rc-layne Bot commented Oct 20, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dougfabris commented Oct 20, 2026 •

edited by coderabbitai Bot

Loading

dionisio-bot Bot commented Oct 20, 2026 •

edited

Loading

changeset-bot Bot commented Oct 20, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

coderabbitai Bot commented Oct 20, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

codecov Bot commented Oct 20, 2026 •

edited

Loading