{{ message }}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$PhoneProductIdis assigned in the LTS branch, but it is never referenced anywhere else inNew-MSIXPackage(or the module). As a result, changing this GUID appears to be a no-op and won’t affect the generated MSIX/manifest, which conflicts with the PR goal of updating Store publishing metadata. Either wirePhoneProductIdinto the generated AppxManifest (or whatever Store metadata consumes it) or remove this unused variable/comment to avoid misleading future changes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good catch. It seems lots of changes in this function is missing, such as the
'$PHONEPRODUCTID$'placeholder in the AppxManifest file.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot check if this still applies