[release/v7.4.15] Update the PhoneProductId to be the official LTS id used by Store by adityapatwardhan · Pull Request #27169 · PowerShell/PowerShell · GitHub
Skip to content

[release/v7.4.15] Update the PhoneProductId to be the official LTS id used by Store#27169

Merged
adityapatwardhan merged 3 commits intoPowerShell:release/v7.4.15from
adityapatwardhan:backport/release/v7.4.15/27077-1e5c02074
Apr 3, 2026
Merged

[release/v7.4.15] Update the PhoneProductId to be the official LTS id used by Store#27169
adityapatwardhan merged 3 commits intoPowerShell:release/v7.4.15from
adityapatwardhan:backport/release/v7.4.15/27077-1e5c02074

Conversation

@adityapatwardhan
Copy link
Copy Markdown
Member

Backport of #27077 to release/v7.4.15

Triggered by @adityapatwardhan on behalf of @daxian-dbw

Original CL Label: CL-BuildPackaging

/cc @PowerShell/powershell-maintainers

Impact

REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.

Tooling Impact

  • Required tooling change
  • Optional tooling change (include reasoning)

Updates release/v7.4.15 packaging metadata so Store publishing uses the official LTS PhoneProductId.

Customer Impact

  • Customer reported
  • Found internally

Regression

REQUIRED: Check exactly one box.

  • Yes
  • No

This is not a regression.

Testing

Cherry-pick applied cleanly with no merge conflicts. Validated commit is present on the backport branch and the change scope is limited to updating PhoneProductId metadata used by Store packaging.

Risk

REQUIRED: Check exactly one box.

  • High
  • Medium
  • Low

The change updates a single packaging identifier value and does not alter runtime engine behavior or cmdlet logic.

@adityapatwardhan adityapatwardhan requested a review from a team as a code owner April 2, 2026 21:55
@adityapatwardhan adityapatwardhan added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Apr 2, 2026
Copilot AI review requested due to automatic review settings April 2, 2026 21:56
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Backport to release/v7.4.15 intended to update MSIX Store metadata for the LTS package by changing the PhoneProductId used during packaging.

Changes:

  • Update the hardcoded LTS PhoneProductId GUID in New-MSIXPackage.

Comment on lines 4295 to 4299
Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$PhoneProductId is assigned in the LTS branch, but it is never referenced anywhere else in New-MSIXPackage (or the module). As a result, changing this GUID appears to be a no-op and won’t affect the generated MSIX/manifest, which conflicts with the PR goal of updating Store publishing metadata. Either wire PhoneProductId into the generated AppxManifest (or whatever Store metadata consumes it) or remove this unused variable/comment to avoid misleading future changes.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good catch. It seems lots of changes in this function is missing, such as the '$PHONEPRODUCTID$' placeholder in the AppxManifest file.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot check if this still applies

@microsoft-github-policy-service microsoft-github-policy-service Bot added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Apr 3, 2026
@microsoft-github-policy-service microsoft-github-policy-service Bot removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Apr 3, 2026
@adityapatwardhan adityapatwardhan enabled auto-merge (squash) April 3, 2026 19:57
@adityapatwardhan adityapatwardhan merged commit 70e5f80 into PowerShell:release/v7.4.15 Apr 3, 2026
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants