Rename file from PingPathCommand.cs to TestPathCommand.cs by ArmaanMcleod · Pull Request #19782 · PowerShell/PowerShell · GitHub
Skip to content

Rename file from PingPathCommand.cs to TestPathCommand.cs#19782

Merged
daxian-dbw merged 1 commit intoPowerShell:masterfrom
ArmaanMcleod:rename-test-path-command-file
Jun 19, 2023
Merged

Rename file from PingPathCommand.cs to TestPathCommand.cs#19782
daxian-dbw merged 1 commit intoPowerShell:masterfrom
ArmaanMcleod:rename-test-path-command-file

Conversation

@ArmaanMcleod
Copy link
Copy Markdown
Contributor

PR Summary

Renaming file from PingPathCommand.cs to TestPathCommand.cs to match cmdlet name better.

PR Context

PR Checklist

@pull-request-quantifier-deprecated
Copy link
Copy Markdown

@iSazonov
Copy link
Copy Markdown
Collaborator

We lost git history if we renamed the file.

@StevenBucher98 StevenBucher98 added the PowerShell-Docs not needed The PR was reviewed and doesn't appear to require a PowerShell Docs update label Jun 12, 2023
@ArmaanMcleod
Copy link
Copy Markdown
Contributor Author

ArmaanMcleod commented Jun 15, 2023

We lost git history if we renamed the file.

@iSazonov Understandable. I've seen PRs in the past like #10659 which have renamed these files to more suitable names.

Is this something we don't do anymore because of git history loss? Happy to close PR if this is the case.

@iSazonov
Copy link
Copy Markdown
Collaborator

Test-Path is not stable (in contrast with Invoke-Expression) so I think the history is important.

Copy link
Copy Markdown
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test-Path has been around since the beginning, so it's pretty stable now. I looked at the change history, and most of them are parts of big logistic changes, such as code cleanup on using directive and etc. So, I think it's okay to take this change.

@daxian-dbw daxian-dbw merged commit 2403e78 into PowerShell:master Jun 19, 2023
@daxian-dbw daxian-dbw added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Jun 19, 2023
@ArmaanMcleod ArmaanMcleod deleted the rename-test-path-command-file branch June 19, 2023 20:58
@ghost
Copy link
Copy Markdown

ghost commented Jun 29, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log No Changes PowerShell-Docs not needed The PR was reviewed and doesn't appear to require a PowerShell Docs update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants