{{ message }}
Renamed wrongly named file#10659
Merged
daxian-dbw merged 1 commit intoPowerShell:masterfrom Oct 7, 2019
Merged
Conversation
PaulHigin
reviewed
Oct 1, 2019
Contributor
PaulHigin
left a comment
There was a problem hiding this comment.
We are not very consistent in our file naming, but I believe the file name should be 'InvokeExpressionCommand.cs'.
@adityapatwardhan Will renaming a source file cause any build/packaging problems?
Member
6a15abb to
4433029
Compare
Collaborator
Author
|
@PaulHigin - I've locally tested that change will still build pwsh & the command runs fine & also renamed the file to |
SteveL-MSFT
approved these changes
Oct 2, 2019
Member
|
@PoshChan please retry macos |
Collaborator
|
@SteveL-MSFT, successfully started retry of |
Member
|
@PaulHigin renaming this file shouldn't cause any issues as build csproj implicitly includes cs files rather than explicitly. packaging only cares about the binary output and not source files. |
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

PR Summary
This PR fixes the incorrectly named InvokeCommandCmdlet.cs which contained Invoke-Expression definition.
PR Context
fix #9807
Make sure file name matches intended content
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.