{{ message }}
Change Read-Host -MaskInput to use existing SecureString path, but return as plain text#13256
Merged
Merged
Conversation
SteveL-MSFT
requested review from
TravisEz13,
adityapatwardhan,
anmenaga and
daxian-dbw
as code owners
…eturn as plain text
SteveL-MSFT
changed the title
Read-Host -MaskInput to use existig SecureString path, but return as plain textRead-Host -MaskInput to use existing SecureString path, but return as plain text
rjmholt
reviewed
Jul 29, 2020
rjmholt
left a comment
rjmholt
left a comment
Collaborator
There was a problem hiding this comment.
The host change makes me think we should have more SDK tests, particularly a test host implementation, so we have a good litmus test for breaking changes in the API surface
rjmholt
reviewed
Jul 29, 2020
rjmholt
approved these changes
Jul 29, 2020
Member
Author
Collaborator
|
@SteveL-MSFT, did not find matching build context: |
daxian-dbw
reviewed
Jul 29, 2020
daxian-dbw
left a comment
daxian-dbw
left a comment
Member
There was a problem hiding this comment.
LGTM except for one minor comment.
Member
|
@SteveL-MSFT Can you please resolve the conflict? mac CI failing tests are marked as pending for now, so CI should pass after you rebase. |
Member
|
@PoshChan Please remind me in 1 hour |
Collaborator
|
@daxian-dbw, this is the reminder you requested 1 hour ago |
daxian-dbw
added
the
CL-General
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
#10908 introduced a new
-MaskInputswitch to enable hiding the input while still returning a string. It did this by introducing a new methodReadLineMaskedAsString(), however, this was not necessary and would not be supported by remoting as it required hosts to implement it. It also did not support use of-MaskInputwith-Prompt.The change here is to revert most of the changes in that PR to instead use existing
ReadLineAsSecureString()method which would already be implemented by different hosts and convert to a string if-MaskInputis used.PR Context
Fix #13011
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.