{{ message }}
Adds Mask Input Parameter to Read-Host#10908
Merged
Merged
Conversation
vexx32
reviewed
Oct 27, 2019
PaulHigin
suggested changes
Oct 29, 2019
10 tasks
PaulHigin
suggested changes
Oct 30, 2019
PaulHigin
suggested changes
Oct 30, 2019
PaulHigin
approved these changes
Oct 30, 2019
Member
Member
|
@PowerShell/powershell-committee reviewed this and is ok with the proposed switch name and functionality. |
Member
|
@davinci26 can you resolve the merge conflict? |
Contributor
Author
|
@PoshChan please retry windows and static |
Collaborator
|
@davinci26, you are not authorized to request a rebuild |
Contributor
Author
|
@SteveL-MSFT FYI I have fixed all merge conflicts. |
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
Collaborator
|
@TravisEz13 It seems the PR ready to merge. |
Read-Host
Collaborator
|
@davinci26 Thanks for your contribution! |
Merged
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

PR Summary
Issue
Adds #10847
Implementation
PSHostUserInterfaceclass with avirtualmethodReadLineMaskedAsString. This method is in betweenReadLineandReadLineAsSecureString.InternalHostUserInterface.csCheck at runtime if the user has provided bothUse parameter sets to make-MaskInputand-AsSecureStringand if so throw an exception.-MaskInputand-AsSecureStringmutually exclusive (this is another application for Parameters Should Support Mutual Exclusion Natively #5175)Happy Hacktoberfest!
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.