Add orthographic projection class by tommygebhardt · Pull Request #101 · NetTopologySuite/ProjNet4GeoAPI · GitHub
Skip to content

Add orthographic projection class#101

Merged
FObermaier merged 2 commits into
NetTopologySuite:developfrom
tommygebhardt:orthographic-projection
Mar 15, 2022
Merged

Add orthographic projection class#101
FObermaier merged 2 commits into
NetTopologySuite:developfrom
tommygebhardt:orthographic-projection

Conversation

@tommygebhardt

Copy link
Copy Markdown
Contributor

Add the orthographic projection as a
Math Transform following the algorithms in
proj4, EPSG Guidance note 7.2 and Snyder's map projections

Add the orthographic projection as a
Math Transform following the algorithms in
proj4, EPSG Guidance note 7.2 and Snyder's map projections
@CLAassistant

CLAassistant commented Mar 14, 2022

Copy link
Copy Markdown

</ItemGroup>

<ItemGroup Condition=" '$(EnableApiCompat)' == 'true' ">
<PackageReference Include="Microsoft.DotNet.ApiCompat" Version="6.0.0-beta.21159.11" PrivateAssets="All" />

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove this? Have you tried to update the package?
The functionality it provides should definetly stay in place.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can just assume that he experienced the same problem described here. anyway, same reply is still valid.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, @DGuidi is right. In order to get the project to compile, I had to remove the reference. I didn't mean to include it in this commit though, that's my mistake.
I can't find that nuget package anywhere on nuget.org, including pre-releases. Where do I restore that package from?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, it will need to already have been in your package cache in order for this to work.

We should have added a NuGet.config file like what NTS has: https://github.com/NetTopologySuite/NetTopologySuite/blob/54ff4b3a21ded301159d12277cf8515b463f3394/NuGet.config#L1-L6

Reset changes to the projnet project
@FObermaier FObermaier merged commit 9a27f0a into NetTopologySuite:develop Mar 15, 2022
@FObermaier

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants