{{ message }}
Repository navigation
refactor(reset)!: remove the v1.4 bool-mask reset compatibility layer (#2474) - #2494
Merged
Merged
Conversation
…#2474) The public reset contract speaks env_ids row indices only. Positional bool masks now fail closed with TypeError in resolve_reset_env_ids; the EventManager mask-form term detection (_detect_mask_form_reset), the dispatch_reset wrapper, and all DeprecationWarning passthroughs are removed in v1.5 instead of v1.6. Tests migrate to env_ids selectors, including stale slow-lane fixtures that referenced the already-removed __call_mask__/reset_mask APIs. The changelog and both migration guides record the immediate removal.
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
unilab.base.reset_selectors.resolve_reset_env_idsnow fails closed withTypeErroron any bool mask; theDeprecationWarningpassthroughs inResetMaskBuffer.resolve/resolve_reset_maskare gone.EventManagerloses the mask-form reset-term boundary:dispatch_reset,_detect_mask_form_reset,_reset_term_mask_form, and the mask dispatch branch in_call_reset_termare removed. Reset event terms are only called asfunc(env, env_ids, **params).SimBackend.apply_reset/ packed reset), the protectedCommandTerm._resample_command(reset_mask)hook,NoiseModel.reset(reset_mask), and the motion-tracking tensor runtime keep the fixed-width mask form.env_idsselectors, including stale slow-lane fixtures that referenced the already-removed__call_mask__/reset_maskAPIs (they were red on main); changelog and both 1.4→1.5 migration guides now record the immediate removal.User-facing impact: passing a bool mask to any public reset boundary (
TorchEnv.reset,ManagerBase.resetand all manager/term reset hooks,EventManager.apply(mode="reset", ...)) now raisesTypeError;EventManager.dispatch_resetno longer exists.Linked Work
Validation
make test-allpassed on the final local head before this PR was created or updatedCommands actually run:
Remote CI route:
main: current-head CI link and status to be recorded once the run starts.Impact
Artifacts
Checklist