iframe-proxy

laffer1 · 2026-06-12T00:37:16Z

Companion to the stable/4.0 fix (#381). master's usr.bin/sqlite3/Makefile
is identical and has the same latent link failure.

Problem

The sqlite3 shell's generate_series extension (seriesCeil/seriesFloor
in contrib/sqlite3/shell.c) references ceil()/floor(), which resolve to
libm under the PIE shell link. The Makefile linked only libsqlite3:

ld: error: undefined symbol: ceil
ld: error: undefined symbol: floor   >>> shell.pieo:(seriesFilter)
*** [sqlite3.full] Error code 1

Fix

LIBADD+= m. Verified: cd usr.bin/sqlite3 && make links cleanly with -lm.

🤖 Generated with Claude Code

Summary by Sourcery

Link the sqlite3 shell binary against libm to resolve unresolved math symbol references in the generate_series extension.

Bug Fixes:

Fix sqlite3 shell link failures caused by unresolved ceil() and floor() symbols when building with PIE.

Build:

Add libm to the sqlite3 shell link libraries in usr.bin/sqlite3/Makefile.

The sqlite3 shell's generate_series extension (seriesCeil/seriesFloor in contrib/sqlite3/shell.c) references ceil() and floor(); under the PIE shell link these resolve to libm symbols. The Makefile only linked libsqlite3, so sqlite3.full failed with: ld: error: undefined symbol: ceil ld: error: undefined symbol: floor >>> referenced by shell.c ... seriesFilter Add LIBADD+= m. Verified: usr.bin/sqlite3 now builds and links cleanly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

sourcery-ai · 2026-06-12T00:37:24Z

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Links the sqlite3 shell binary against libm to resolve ceil/floor references used by the generate_series extension under PIE linking.

File-Level Changes

Change	Details	Files
Link sqlite3 shell against libm to fix missing math symbol references during PIE build.	Add libm to the list of libraries linked for the sqlite3 shell binary Ensure ceil() and floor() calls in the generate_series extension resolve correctly at link time under PIE	`usr.bin/sqlite3/Makefile`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

gemini-code-assist

Code Review

This pull request updates the Makefile for the sqlite3 utility to link against the math library by adding LIBADD+= m. There are no review comments, and I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

github-actions · 2026-06-12T00:40:39Z

Claude finished @laffer1's task —— View job

Code Review Complete ✅

Todo List:

Read repository guidelines (CLAUDE.md)
Examine the modified Makefile
Review for correctness bugs, malloc/free symmetry, bounds checking
Check style(9) compliance (8-space tabs, 80-col)
Verify no prohibited areas (assembly, contrib/mksh) are touched
Assess security implications
Provide comprehensive review feedback

Review Summary

✅ APPROVED - This is a correct and necessary fix.

Analysis

The change adds LIBADD+= m to /usr.bin/sqlite3/Makefile:15 to link the sqlite3 shell against libm (math library).

Root Cause Confirmed: The sqlite3 shell includes a generate_series extension that uses seriesCeil() and seriesFloor() functions, which internally call the standard math library functions ceil() and floor() (lines 8188-8189 in contrib/sqlite3/shell.c). Under PIE linking, these symbols require explicit linking to libm.

Code Review Results

✅ Correctness:

Fix addresses the exact link failure described in the PR
Proper use of BSD make LIBADD variable for library dependencies
Follows MidnightBSD build system conventions

✅ Style Compliance:

Uses 8-space tabs (line 15: tab before m)
Under 80 columns
Matches existing style in the file
Follows style(9) requirements

✅ Security & Safety:

No malloc/free issues (Makefile only)
No bounds checking concerns
No assembly or prohibited areas touched
Adding math library linkage is standard and safe

✅ Build System Compliance:

Correct usage of LIBADD+= syntax for BSD make
Consistent with how sqlite3 library is added on line 14
Standard approach for math library dependency

Minor Observations

Typo in header: Line 1 has $MidnigtBSD: (missing 'h' in MidnightBSD), but this appears to be a pre-existing issue unrelated to this change.
Commented readline: Line 16 shows # readline comment, suggesting future readline support may also need LIBADD+= readline when implemented.

Verification

The fix correctly resolves the link failure for PIE builds where ceil() and floor() symbols are undefined. This is the minimal and appropriate solution following BSD conventions.

Job Run

sourcery-ai

Hey - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

gemini-code-assist Bot reviewed Jun 12, 2026

View reviewed changes

laffer1 mentioned this pull request Jun 12, 2026

usr.bin/sqlite3: link the shell against libm #383

Merged

laffer1 merged commit bc83826 into master Jun 12, 2026
7 of 13 checks passed

sourcery-ai Bot reviewed Jun 12, 2026

View reviewed changes

laffer1 deleted the fix/sqlite3-shell-libm-master branch June 15, 2026 13:54

Sunbelt Computer Software

PL/B Language Development and Support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

usr.bin/sqlite3: link the shell against libm#382

usr.bin/sqlite3: link the shell against libm#382
laffer1 merged 1 commit into
masterfrom
fix/sqlite3-shell-libm-master

laffer1 commented Jun 12, 2026 •

edited by sourcery-ai Bot

Loading

Uh oh!

sourcery-ai Bot commented Jun 12, 2026 •

edited

Loading

Reviewer's Guide

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

github-actions Bot commented Jun 12, 2026 •

edited

Loading

Uh oh!

Uh oh!

sourcery-ai Bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Uh oh!

Conversation

laffer1 commented Jun 12, 2026 • edited by sourcery-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Fix

Summary by Sourcery

Uh oh!

sourcery-ai Bot commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

github-actions Bot commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Complete ✅

Todo List:

Review Summary

Analysis

Code Review Results

Minor Observations

Verification

Uh oh!

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

laffer1 commented Jun 12, 2026 •

edited by sourcery-ai Bot

Loading

sourcery-ai Bot commented Jun 12, 2026 •

edited

Loading

github-actions Bot commented Jun 12, 2026 •

edited

Loading