{{ message }}
usr.bin/sqlite3: link the shell against libm (fixes stable/4.0 build)#381
Merged
Conversation
The sqlite3 shell's generate_series extension (seriesCeil/seriesFloor in
contrib/sqlite3/shell.c) references ceil() and floor(); under the PIE
shell link these resolve to libm symbols. The Makefile only linked
libsqlite3, so sqlite3.full failed with:
ld: error: undefined symbol: ceil
ld: error: undefined symbol: floor
>>> referenced by shell.c ... seriesFilter
Add LIBADD+= m. Verified: usr.bin/sqlite3 now builds and links cleanly.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Makefile for the sqlite3 utility to link against the math library by adding LIBADD+= m. There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This was referenced Jun 12, 2026
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
stable/4.0buildworld fails linking the sqlite3 shell:Cause
contrib/sqlite3/shell.c'sgenerate_seriesextension definesseriesCeil()/seriesFloor()usingceil()/floor(). Under the PIE shelllink those resolve to libm symbols, but
usr.bin/sqlite3/Makefilelinkedonly
libsqlite3(LIBADD+= sqlite3).Fix
LIBADD+= m.Verification
cd usr.bin/sqlite3 && makenow builds clean — the link picks up-lm(
.../lib/msun -lm) andsqlite3.fulllinks/strips successfully.Note:
master'susr.bin/sqlite3/Makefileis identical (no libm) and likelyneeds the same change; happy to send a companion PR.
🤖 Generated with Claude Code
Summary by Sourcery
Build: