Update for python 3.12 by EliusSolis · Pull Request #310 · JHUISI/charm · GitHub
Skip to content

Update for python 3.12 - #310

Merged
jakinyele merged 2 commits into
JHUISI:devfrom
EliusSolis:dev
Jan 23, 2025
Merged

jakinyele merged 2 commits into
JHUISI:devfrom
EliusSolis:dev

Conversation

@EliusSolis

Copy link
Copy Markdown
Contributor

Fixes to reflect changes in cython 3.11 and 3.12, mainly PEP 674 and python/cpython#101292

@Herbrant

Copy link
Copy Markdown

@yueryang yueryang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the nice update. I used this version to build the Python charm for Python 3.12 and it worked fine. I have been using this version with Python 3.12 under the Ubuntu (24.04.1 LTS) operating system (WSL) for over a month. Everything seems pretty. Testing schemes work correctly. It is my sincere hope that this branch can be merged. Merry Christmas and Happy New Year.

@jakinyele jakinyele left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jakinyele
jakinyele merged commit 0661115 into JHUISI:dev Jan 23, 2025
@yueryang

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants