feat!: remove Python 2.7 from tested versions#13675
Conversation
This file should be no longer required since the only difference was 2.7
product-auto-label
Bot
added
samples
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly removes Python 2.7 from the tested versions to align with its deprecation and removal from the testing environment. The changes, which include updating ALL_VERSIONS in noxfile-template.py and deleting the specialized appengine/standard/noxfile-template.py, are logical and directly address the issue of failing builds. The implementation is sound and I have no concerns.
glasnt
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
|
Since cl/852425680 has been merged, a I'm not yet sure if/how to remove this deprecated check from PRs, apart from removing it as a required check before the PR can pass. PRs created before the CL was merged will also have this failing check that is not re-run on |
* feat!: remove Python 2.7 from ALL_VERSIONS * remove app engine forked noxfile-template This file should be no longer required since the only difference was 2.7 * remove 2.7 configurations
4 participants
With #13596, we both added Python 3.14, but also removed python 2.7 from the base testing image.
The way testing is currently setup, while most tests (apart from App Engine Standard) are configured to skip Python 2.7, nox only handles this skip within the versioned environment.
For example, previously these checks would show:
Since the merge of 13596, these now appear as:
With the deprecation of Python 2.7 for App Engine Standard first-generation just over 6 weeks away, we should be able to remove this version from our Nox and Kokoro configurations, thus preventing this failing error.
Additionally, since the copy of noxfile-template in App Engine Standard was primarily there because of Python 2.7, this forked version has been deleted.