iframe-proxy

parthea · 2025-10-07T19:32:27Z

Similar to #12780

gemini-code-assist · 2025-10-07T19:32:40Z

Summary of Changes

Hello @parthea, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the .kokoro/docker/Dockerfile to incorporate Python 3.14.0 into the samples testing image. This enhancement ensures that the testing infrastructure is prepared for the latest Python release and benefits from updated patch versions for several other Python versions, thereby improving the robustness and currency of the test environment.

Highlights

Python 3.14 Support: Added Python 3.14.0 to the list of Python versions installed and tested within the samples testing Docker image.
Python Patch Version Updates: Updated the patch versions for several existing Python releases, including 3.9.23, 3.10.18, 3.11.13, 3.12.11, and 3.13.8, ensuring the testing environment uses more recent stable releases.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request updates the Python versions in the testing Docker image, adding support for Python 3.14 and refreshing patch versions for others. My feedback focuses on improving the readability and maintainability of the Dockerfile where these versions are listed.

vchudnov-g

One small suggestion

vchudnov-g · 2025-10-07T21:25:24Z

+  3.12.11 \
+  3.13.8 \
+  3.14.0" \
+  && for PYTHON_VERSION in $PYTHON_VERSIONS; do \


I'd prefer to avoid variables that differ only by one letter. How about
for VERSION in $PYTHON_VERSIONS or for PYTHON_VERSION in $ALL_PYTHON_VERSIONS?

glasnt · 2025-10-15T23:51:04Z

-  && echo "disable-ipv6" >> "${GNUPGHOME}/dirmngr.conf" \
-  && /tmp/fetch_gpg_keys.sh \
-  && PYTHON_VERSIONS="\
-  2.7.18 \


This commit removes Python 2.7 entirely from the base image. Will this affect CI?

Per an earlier update, #13066 (comment) indicates this was going to be removed, but it's still an active check on this PR. I also recall an earlier PR (can't find it now) where removing Python 2.7 breaks kokoro. Was that resolved? I'm cautious of an update that adds a new python version but also coincidently removes an older major version.

glasnt · 2025-10-15T23:55:25Z

Guessing based on #12780 that we can't test the new image works until after this PR is merged and new changes come in?

I'm also guessing that the changes to this Docker image aren't tested until after this PR is merged and the image is rebuilt? (Automatically via a Cloud Build trigger, by the look of it).

Is there a manual way to test that the Dockerfile changes work before merging the PR?

(The failing tests here appear to all be related to individual tests not working, which I will begin addressing separetely.)

chalmerlowe · 2025-11-20T15:56:36Z

iennae

There are some samples that need to be updated; we're prioritizing new infra and unblocking samples that need the new runtimes.

parthea requested review from a team as code owners October 7, 2025 19:32

product-auto-label Bot added the samples Issues that are directly related to samples. label Oct 7, 2025

parthea force-pushed the add-python-314 branch from 417c600 to 3a2ae38 Compare October 7, 2025 19:33

gemini-code-assist Bot reviewed Oct 7, 2025

View reviewed changes

Comment thread .kokoro/docker/Dockerfile Outdated

vchudnov-g approved these changes Oct 7, 2025

View reviewed changes

glasnt reviewed Oct 15, 2025

View reviewed changes

iennae added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Dec 12, 2025

kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 12, 2025

This was referenced Dec 12, 2025

feat: support Python 3.14 googleapis/google-auth-library-python#1822

Merged

Finish Python 3.14 support googleapis/google-cloud-python#15135

Open

daniel-sanche approved these changes Dec 12, 2025

View reviewed changes

vchudnov-g added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 15, 2025

kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 15, 2025

Linchin mentioned this pull request Dec 15, 2025

feat: support python 3.14 googleapis/python-bigquery-magics#165

Merged

4 tasks

parthea and others added 6 commits December 16, 2025 12:50

feat: add Python 3.14 to samples testing image

96f4099

address review feedback

6c0bd11

formatting

574c712

wip

c09e441

remove gpg;add sigstore;remove python 2.7 which doesn't support sigstore

b0ccf52

fix typo

40f6646

vchudnov-g force-pushed the add-python-314 branch from f3c7054 to 40f6646 Compare December 16, 2025 20:51

chore: add Py3.14 to noxfile-template

7d1b3e2

vchudnov-g requested review from a team as code owners December 16, 2025 22:34

This was referenced Dec 17, 2025

chore: skip failing samples due to public access prevention enforcement googleapis/python-storage#1668

Merged

chore: add system test for cloud path googleapis/python-storage#1666

Merged

iennae approved these changes Dec 17, 2025

View reviewed changes

iennae merged commit 181247a into main Dec 17, 2025
7 of 15 checks passed

iennae deleted the add-python-314 branch December 17, 2025 20:30

glasnt mentioned this pull request Dec 18, 2025

feat!: remove Python 2.7 from tested versions #13675

Merged

2 tasks

chandra-siri mentioned this pull request Dec 18, 2025

feat: expose persisted size in mrd googleapis/python-storage#1671

Merged

vchudnov-g added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 19, 2025

Sunbelt Computer Software

PL/B Language Development and Support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add Python 3.14 to samples testing image#13596

feat: add Python 3.14 to samples testing image#13596
iennae merged 7 commits into
mainfrom
add-python-314

parthea commented Oct 7, 2025

Uh oh!

gemini-code-assist Bot commented Oct 7, 2025

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

vchudnov-g left a comment

Uh oh!

vchudnov-g Oct 7, 2025

Uh oh!

glasnt Oct 15, 2025

Uh oh!

glasnt commented Oct 15, 2025

Uh oh!

chalmerlowe commented Nov 20, 2025

Uh oh!

iennae left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

parthea commented Oct 7, 2025

Uh oh!

gemini-code-assist Bot commented Oct 7, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

vchudnov-g left a comment

Choose a reason for hiding this comment

Uh oh!

vchudnov-g Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

glasnt Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

glasnt commented Oct 15, 2025

Uh oh!

chalmerlowe commented Nov 20, 2025

Uh oh!

iennae left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants