iframe-proxy

dlech · 2025-09-06T17:07:55Z

According to the spec, the status properties on USBInTransferResult and USBIsochronousInTransferPacket are not optional and will always be present.

It is also logical that if the constructor argument cannot be undefined, then the property cannot be undefined.

Please fill in this template.

Use a meaningful title for the pull request. Include the name of the package modified.
Test the change in your own code. (Compile and run.)
Add or edit tests to reflect the change.
Follow the advice from the readme.
Avoid common mistakes.
Run pnpm test <package to test>.

Select one of these and delete the others:

If changing an existing definition:

Provide a URL to documentation or source code which provides context for the suggested changes: <>
If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

According to the spec, the status properties on `USBInTransferResult` and `USBIsochronousInTransferPacket` are not optional and will always be present. - https://wicg.github.io/webusb/#usbintransferresult - https://wicg.github.io/webusb/#usbisochronousintransferpacket It is also logical that if the constructor argument cannot be undefined, then the property cannot be undefined.

typescript-bot · 2025-09-06T17:08:32Z

@dlech Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

w3c-web-usb — on npm, on unpkg

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

✅ No merge conflicts
✅ Continuous integration tests have passed
✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 73622,
  "author": "dlech",
  "headCommitOid": "a64ea06fc2d6f010f825606f3ac6277ab4796901",
  "mergeBaseOid": "a96fb22be6855f14d6cd9f83117d74c197e91319",
  "lastPushDate": "2025-09-06T17:07:55.000Z",
  "lastActivityDate": "2025-09-30T07:25:55.000Z",
  "mergeOfferDate": "2025-09-29T18:27:59.000Z",
  "mergeRequestDate": "2025-09-30T07:25:55.000Z",
  "mergeRequestUser": "dlech",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "w3c-web-usb",
      "kind": "edit",
      "files": [
        {
          "path": "types/w3c-web-usb/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/w3c-web-usb/w3c-web-usb-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "larsgk",
        "thegecko",
        "yume-chan"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "jakebailey",
      "date": "2025-09-29T18:27:18.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 3262641748,
  "ciResult": "pass"
}

typescript-bot · 2025-09-06T17:08:34Z

🔔 @larsgk @thegecko @yume-chan — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

yume-chan · 2025-09-09T06:43:58Z

@@ -64,7 +64,7 @@ declare class USBAlternateInterface {
 declare class USBInTransferResult {
    constructor(status: USBTransferStatus, data?: DataView);
    readonly data?: DataView | undefined;


Should this also be

Suggested change

readonly data?: DataView | undefined;

readonly data: DataView | null;

Same on line 78

The spec didn't say "nullable" on this one like it did on #73568, so that is why I didn't change it. I haven't had a chance to test on real hardware yet though to see what it actually does in a browser.

typescript-bot · 2025-09-17T18:49:12Z

Re-ping @larsgk, @thegecko, @yume-chan:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

typescript-bot · 2025-09-24T18:49:23Z

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @dlech.

(Ping @larsgk, @thegecko, @yume-chan.)

typescript-bot · 2025-09-29T18:27:59Z

@dlech: Everything looks good here. I am ready to merge this PR (at a64ea06) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@larsgk, @thegecko, @yume-chan: you can do this too.)

dlech · 2025-09-30T07:25:55Z

typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label Sep 6, 2025

typescript-bot added this to Pull Request Status Board Sep 6, 2025

typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board Sep 6, 2025

Merge branch 'master' into w3c-web-usb-fixes2

a64ea06

yume-chan reviewed Sep 9, 2025

View reviewed changes

typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Sep 17, 2025

typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in Pull Request Status Board Sep 24, 2025

jakebailey approved these changes Sep 29, 2025

View reviewed changes

typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Sep 29, 2025

typescript-bot moved this from Needs Maintainer Action to Waiting for Author to Merge in Pull Request Status Board Sep 29, 2025

typescript-bot moved this from Waiting for Author to Merge to Recently Merged in Pull Request Status Board Sep 30, 2025

typescript-bot merged commit 0f7ba93 into DefinitelyTyped:master Sep 30, 2025
4 checks passed

dlech deleted the w3c-web-usb-fixes2 branch September 30, 2025 07:27

typescript-bot removed this from Pull Request Status Board Oct 16, 2025

Sunbelt Computer Software

PL/B Language Development and Support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

types/w3c-web-usb: status properties are not undefined#73622

types/w3c-web-usb: status properties are not undefined#73622
typescript-bot merged 2 commits into
DefinitelyTyped:masterfrom
dlech:w3c-web-usb-fixes2

dlech commented Sep 6, 2025

Uh oh!

typescript-bot commented Sep 6, 2025 •

edited

Loading

Uh oh!

typescript-bot commented Sep 6, 2025

Uh oh!

yume-chan Sep 9, 2025 •

edited

Loading

Uh oh!

dlech Sep 17, 2025

Uh oh!

typescript-bot commented Sep 17, 2025

Uh oh!

typescript-bot commented Sep 24, 2025

Uh oh!

typescript-bot commented Sep 29, 2025

Uh oh!

dlech commented Sep 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	readonly data?: DataView \| undefined;
	readonly data: DataView \| null;

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

dlech commented Sep 6, 2025

Uh oh!

typescript-bot commented Sep 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

1 package in this PR

Code Reviews

Status

Uh oh!

typescript-bot commented Sep 6, 2025

Uh oh!

yume-chan Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dlech Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

typescript-bot commented Sep 17, 2025

Uh oh!

typescript-bot commented Sep 24, 2025

Uh oh!

typescript-bot commented Sep 29, 2025

Uh oh!

dlech commented Sep 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

typescript-bot commented Sep 6, 2025 •

edited

Loading

yume-chan Sep 9, 2025 •

edited

Loading