@dlech Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

• w3c-web-usb — on npm, on unpkg
  • owner-approval: @yume-chan

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

{
  "type": "info",
  "now": "-",
  "pr_number": 73568,
  "author": "dlech",
  "headCommitOid": "81275609e95dc1d25a33aab1ceee4c7b75066775",
  "mergeBaseOid": "fe9f2bfc7c6569a075c68ed4cb1a1e0a3d900d00",
  "lastPushDate": "2025-08-28T19:31:28.000Z",
  "lastActivityDate": "2025-09-06T16:28:00.000Z",
  "mergeOfferDate": "2025-09-06T16:27:13.000Z",
  "mergeRequestDate": "2025-09-06T16:28:00.000Z",
  "mergeRequestUser": "dlech",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "w3c-web-usb",
      "kind": "edit",
      "files": [
        {
          "path": "types/w3c-web-usb/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/w3c-web-usb/w3c-web-usb-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "larsgk",
        "thegecko",
        "yume-chan"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "yume-chan",
      "date": "2025-09-06T16:26:33.000Z",
      "isMaintainer": false
    },
    {
      "type": "stale",
      "reviewer": "RyanCavanaugh",
      "date": "2025-09-03T03:19:56.000Z",
      "abbrOid": "a073eaf"
    }
  ],
  "mainBotCommentID": 3234703935,
  "ciResult": "pass"
}

🔔 @larsgk @thegecko @yume-chan — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@dlech One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

@RyanCavanaugh, @yume-chan Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

I just dropped the configuration change commit. Since CI is passing, that tells me that I just have a local problem that was triggering the need for that.

FWIW, this is the error I am seeing locally. It looks like maybe I need to wipe out node_modules and try again.

Error: 
/home/david/work/DefinitelyTyped/types/w3c-web-usb/index.d.ts
  1:1  error  Definition for rule '@typescript-eslint/no-wrapper-object-types' was not found  @typescript-eslint/no-wrapper-object-types
  1:1  error  Definition for rule '@typescript-eslint/no-unsafe-function-type' was not found  @typescript-eslint/no-unsafe-function-type

/home/david/work/DefinitelyTyped/types/w3c-web-usb/w3c-web-usb-tests.ts
  1:1  error  Definition for rule '@typescript-eslint/no-wrapper-object-types' was not found  @typescript-eslint/no-wrapper-object-types
  1:1  error  Definition for rule '@typescript-eslint/no-unsafe-function-type' was not found  @typescript-eslint/no-unsafe-function-type

@dlech: Everything looks good here. I am ready to merge this PR (at 8127560) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@larsgk, @thegecko, @yume-chan: you can do this too.)

@RyanCavanaugh Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

Ready to merge