Clean up Platform and CLIHelper component by PerfectSlayer · Pull Request #9101 · DataDog/dd-trace-java · GitHub
Skip to content

Clean up Platform and CLIHelper component#9101

Merged
PerfectSlayer merged 1 commit into
masterfrom
bbujon/environment-step6
Jul 7, 2025
Merged

Clean up Platform and CLIHelper component#9101
PerfectSlayer merged 1 commit into
masterfrom
bbujon/environment-step6

Conversation

@PerfectSlayer

@PerfectSlayer PerfectSlayer commented Jul 4, 2025

Copy link
Copy Markdown
Contributor

What Does This Do

This PR cleans up Platform methods and the original CLIHelper component.

Follow-up to:

Motivation

The behavior moved into the dedicated environment component.

Additional Notes

This should be the last PR for the environment component for now.
Next steps would be to keep porting related features to this component.

Contributor Checklist

Jira ticket: LANGPLAT-458

@PerfectSlayer PerfectSlayer added tag: no release notes Changes to exclude from release notes type: refactoring comp: platform Platform labels Jul 4, 2025
@pr-commenter

pr-commenter Bot commented Jul 4, 2025

Copy link
Copy Markdown

@PerfectSlayer PerfectSlayer force-pushed the bbujon/environment-step5 branch from 4d467d1 to 115d3dc Compare July 4, 2025 05:12
@PerfectSlayer PerfectSlayer force-pushed the bbujon/environment-step6 branch from 721cba2 to fea3156 Compare July 4, 2025 05:17
@pr-commenter

pr-commenter Bot commented Jul 4, 2025

Copy link
Copy Markdown

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1751606772 1751607155
end_time 2025-07-04T05:27:33 2025-07-04T05:33:55
git_branch master bbujon/environment-step6
git_commit_sha dd59589 fea3156fa8b79d432948df471e247e0ff7110769
start_time 2025-07-04T05:26:13 2025-07-04T05:32:36
See matching parameters
Baseline Candidate
ci_job_id 1013696559 1013696559
ci_pipeline_id 69642172 69642172
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1751605910 1751605910

Summary

Found 6 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 6 unstable metrics.

scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:basic better
[-11.729µs; -3.295µs] or [-4.170%; -1.172%]
same same unstable
[+9.835µs; +202.784µs] or [+1.263%; +26.039%]
unstable
[-71.228op/s; +193.179op/s] or [-2.920%; +7.920%]
scenario:loop better
[-654.659µs; -648.815µs] or [-6.148%; -6.093%]
better
[-679.771µs; -617.779µs] or [-6.281%; -5.708%]
better
[-693.821µs; -583.026µs] or [-6.358%; -5.342%]
better
[-824.996µs; -475.204µs] or [-7.351%; -4.234%]
better
[+4.956op/s; +6.571op/s] or [+5.426%; +7.195%]
See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-27.284µs; +14.046µs] or [-9.732%; +5.010%]
unstable
[-38.752µs; +23.479µs] or [-12.153%; +7.363%]
unstable
[-51.205µs; +32.715µs] or [-15.319%; +9.788%]
unstable
[+34.917µs; +246.017µs] or [+3.898%; +27.467%]
same
Request duration reports for reports
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (318.88 µs) : 284, 354
.   : milestone, 319,
basic (309.805 µs) : 302, 318
.   : milestone, 310,
loop (10.823 ms) : 10801, 10844
.   : milestone, 10823,
section candidate
noprobe (311.244 µs) : 288, 335
.   : milestone, 311,
basic (303.612 µs) : 295, 312
.   : milestone, 304,
loop (10.174 ms) : 10139, 10208
.   : milestone, 10174,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 318.88 µs [284.218 µs, 353.543 µs]
basic 309.805 µs [301.648 µs, 317.962 µs]
loop 10.823 ms [10.801 ms, 10.844 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 311.244 µs [287.713 µs, 334.775 µs]
basic 303.612 µs [295.119 µs, 312.106 µs]
loop 10.174 ms [10.139 ms, 10.208 ms]

Base automatically changed from bbujon/environment-step5 to master July 4, 2025 13:58
@PerfectSlayer PerfectSlayer force-pushed the bbujon/environment-step6 branch from fea3156 to eaf8c40 Compare July 4, 2025 14:00
@PerfectSlayer PerfectSlayer marked this pull request as ready for review July 4, 2025 14:00
@PerfectSlayer PerfectSlayer requested review from a team as code owners July 4, 2025 14:00
@PerfectSlayer PerfectSlayer requested review from sarahchen6 and smola and removed request for a team July 4, 2025 14:00
@PerfectSlayer PerfectSlayer enabled auto-merge (squash) July 4, 2025 14:10
@PerfectSlayer PerfectSlayer merged commit bbdc0b7 into master Jul 7, 2025
508 of 509 checks passed
@PerfectSlayer PerfectSlayer deleted the bbujon/environment-step6 branch July 7, 2025 07:24
@github-actions github-actions Bot added this to the 1.51.0 milestone Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: platform Platform tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants