Migrate smoke tests to environment component by PerfectSlayer · Pull Request #9100 · DataDog/dd-trace-java · GitHub
Skip to content

Migrate smoke tests to environment component#9100

Merged
PerfectSlayer merged 1 commit into
masterfrom
bbujon/environment-step5
Jul 4, 2025
Merged

Migrate smoke tests to environment component#9100
PerfectSlayer merged 1 commit into
masterfrom
bbujon/environment-step5

Conversation

@PerfectSlayer

@PerfectSlayer PerfectSlayer commented Jul 4, 2025

Copy link
Copy Markdown
Contributor

What Does This Do

This PR migrates the internal API to the environment components.

Follow-up to:

Motivation

Additional Notes

This PR is mainly refactoring to use the new methods from the environment component rather than the original ones in Platform.

Contributor Checklist

Jira ticket: LANGPLAT-458

@PerfectSlayer PerfectSlayer added tag: no release notes Changes to exclude from release notes type: refactoring labels Jul 4, 2025
@PerfectSlayer PerfectSlayer requested a review from a team as a code owner July 4, 2025 03:49
@PerfectSlayer PerfectSlayer added the comp: platform Platform label Jul 4, 2025
@PerfectSlayer PerfectSlayer requested review from a team as code owners July 4, 2025 03:49
@PerfectSlayer PerfectSlayer requested review from Mariovido and ygree July 4, 2025 03:49
@pr-commenter

pr-commenter Bot commented Jul 4, 2025

Copy link
Copy Markdown

@pr-commenter

pr-commenter Bot commented Jul 4, 2025

Copy link
Copy Markdown

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1751606689 1751607075
end_time 2025-07-04T05:26:09 2025-07-04T05:32:35
git_branch master bbujon/environment-step5
git_commit_sha dd59589 115d3dc
start_time 2025-07-04T05:24:50 2025-07-04T05:31:16
See matching parameters
Baseline Candidate
ci_job_id 1013695042 1013695042
ci_pipeline_id 69642128 69642128
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1751605909 1751605909

Summary

Found 5 performance improvements and 0 performance regressions! Performance is the same for 5 metrics, 5 unstable metrics.

scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:loop better
[-863.074µs; -783.906µs] or [-7.985%; -7.252%]
better
[-903.044µs; -813.500µs] or [-8.225%; -7.410%]
better
[-896.958µs; -776.709µs] or [-8.109%; -7.022%]
better
[-1.248ms; -0.758ms] or [-10.845%; -6.582%]
better
[+6.628op/s; +8.314op/s] or [+7.357%; +9.229%]
See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-23.635µs; +16.274µs] or [-8.483%; +5.841%]
unstable
[-39.791µs; +25.868µs] or [-12.386%; +8.052%]
unstable
[-50.842µs; +35.020µs] or [-15.164%; +10.445%]
unstable
[-163.415µs; +72.260µs] or [-17.207%; +7.609%]
same
scenario:basic same same same unstable
[-94.434µs; +52.893µs] or [-11.418%; +6.395%]
same
Request duration reports for reports
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (321.262 µs) : 283, 360
.   : milestone, 321,
basic (316.082 µs) : 308, 324
.   : milestone, 316,
loop (10.979 ms) : 10924, 11034
.   : milestone, 10979,
section candidate
noprobe (314.3 µs) : 292, 336
.   : milestone, 314,
basic (310.783 µs) : 303, 319
.   : milestone, 311,
loop (10.121 ms) : 10100, 10142
.   : milestone, 10121,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 321.262 µs [282.876 µs, 359.648 µs]
basic 316.082 µs [308.271 µs, 323.893 µs]
loop 10.979 ms [10.924 ms, 11.034 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 314.3 µs [292.365 µs, 336.236 µs]
basic 310.783 µs [302.696 µs, 318.87 µs]
loop 10.121 ms [10.1 ms, 10.142 ms]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking does it makes to deprecate Platform API ?

@PerfectSlayer PerfectSlayer Jul 4, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Platform will still be use for native image test and capture for now.
You can check its clean up state in #9101

@PerfectSlayer PerfectSlayer merged commit 1de42c8 into master Jul 4, 2025
515 checks passed
@PerfectSlayer PerfectSlayer deleted the bbujon/environment-step5 branch July 4, 2025 13:58
@github-actions github-actions Bot added this to the 1.51.0 milestone Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: platform Platform tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants