{{ message }}
Repository navigation
Fix missing absolute path resolving in ParamsLoader - #6828
Merged
Merged
Conversation
This is a regression bugfix for release 5.2.0. With Codeception#6767 the ParamsLoader was streamlined, but when previously `$paramsFile` was passed to the loader methods, now only `$paramStorage` is passed, which misses getting converted to an absolute path via `codecept_absolute_path()`. This patch restores utilizing `$paramsFile` and also uses that to emit warnings when a file cannot be loaded. This bug caused missing file resolving, because software like TYPO3 for example executes tests from the repo directory `typo3/sysext/core/Tests/codeception.yml` and uses: ``` params: - parameters.yml - env.yml ``` and expects that the file is found next to the `codeception.yml` file in the same directory, and thus a breaking change.
grossmannmartin
added a commit
to shopsys/shopsys
that referenced
this pull request
Feb 17, 2025
1 task done
grossmannmartin
added a commit
to shopsys/shopsys
that referenced
this pull request
Feb 17, 2025
TavoNiievez
approved these changes
Feb 20, 2025
Member
Contributor
Author
|
Thanks for the trust in advance. :) I'll see what I can do for some tests, I haven't yet checked this out, but should be possible. Give me a day or two. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a regression bugfix for release 5.2.0.
With #6767 the ParamsLoader was streamlined, but when previously
$paramsFilewas passed to the loader methods, now only$paramStorageis passed, which misses getting converted to an absolute path viacodecept_absolute_path().This patch restores utilizing
$paramsFileand also uses that to emit warnings when a file cannot be loaded.This bug caused missing file resolving, because software like TYPO3 for example executes tests from the repo directory
typo3/sysext/core/Tests/codeception.ymland uses:and expects that the file is found next to the
codeception.ymlfile in the same directory, and thus a breaking change.Closes #6829