{{ message }}
Repository navigation
Simplify Lib classes - #6767
Merged
Merged
Simplify Lib classes#6767
Conversation
Member
Arhell
approved these changes
Jul 6, 2024
Collaborator
I'd say just merge this! |
Collaborator
|
@TavoNiievez what's your confidence level on this? Can I go ahead and merge this or do you feel there's specific things that need an extra good look? |
Member
Author
|
@SamMousa Well, I had gotten used to Naktibalda checking me this kind of PR where I change many things at once, since he is (or was?) who had a more general knowledge about what is susceptible to generate problems if changed, even if the tests are going OK. If I had to answer your question I would say 85% sure that all changes were applied safely. |
Collaborator
|
I'm gonna defer to him, and gonna ping him hoping he'll give the okay then! @Naktibalda you up for reviewing this? |
Member
Author
garvinhicking
added a commit
to garvinhicking/Codeception
that referenced
this pull request
Feb 17, 2025
This is a regression bugfix for release 5.2.0. With Codeception#6767 the ParamsLoader was streamlined, but when previously `$paramsFile` was passed to the loader methods, now only `$paramStorage` is passed, which misses getting converted to an absolute path via `codecept_absolute_path()`. This patch restores utilizing `$paramsFile` and also uses that to emit warnings when a file cannot be loaded. This bug caused missing file resolving, because software like TYPO3 for example executes tests from the repo directory `typo3/sysext/core/Tests/codeception.yml` and uses: ``` params: - parameters.yml - env.yml ``` and expects that the file is found next to the `codeception.yml` file in the same directory, and thus a breaking change.
This was referenced Feb 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
300 additions & 419 deletions.