{{ message }}
Add readBigStrict and use it in buffer deserialization#107196
Merged
Conversation
Contributor
clickhouse-gh
Bot
added
the
pr-not-for-changelog
![clickhouse-gh[bot]](https://avatars.githubusercontent.com/in/928874?s=60&v=4){kind=small}
| data.resize(initial_size + bytes_to_read); | ||
| stream->ignore(bytes_to_skip); | ||
| size_t size = stream->readBig(reinterpret_cast<char*>(&data[initial_size]), bytes_to_read); | ||
| if (size != bytes_to_read) |
Contributor
There was a problem hiding this comment.
This guard is the behavioral contract of the PR, but there is no regression test for it. Please add a focused test that creates a MergeTree part using string_serialization_version = with_size_stream, truncates the String data stream while leaving the size stream intact, and verifies that reading the part fails with this INCORRECT_DATA path instead of returning a malformed ColumnString or surfacing a later LOGICAL_ERROR. Without coverage, the next readBig refactor can silently reintroduce the partial-read behavior this is fixing.
Ergus
changed the title
readBigStrict and use it in buffer deserialization
Contributor
LLVM Coverage Report
Changed lines: Changed C/C++ lines covered by tests: 17/19 (89.47%) | Lost baseline coverage: none · Uncovered code |
Avogar
approved these changes
Jun 12, 2026
Merged
via the queue into
ClickHouse:master
with commit Jun 12, 2026
dabafca
164 of 166 checks passed
robot-clickhouse-ci-1
added
the
pr-synced-to-cloud
pull Bot
pushed a commit
to AKJUS/ClickHouse
that referenced
this pull request
Jun 17, 2026
Tests for changes in ClickHouse#107196
Contributor
This was referenced Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a size match check after
readBigChangelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
...
Version info
26.6.1.707