Repair subtree2 by PKartaviy · Pull Request #1 · ClickHouse/ClickHouse · GitHub
Skip to content

Repair subtree2#1

Merged
alexey-milovidov merged 6 commits into
masterfrom
repair-subtree2
Jun 8, 2016
Merged

Repair subtree2#1
alexey-milovidov merged 6 commits into
masterfrom
repair-subtree2

Conversation

@PKartaviy

@PKartaviy PKartaviy commented Jun 8, 2016 •
edited by alexey-milovidov
Loading

Copy link
Copy Markdown
Contributor

Edited:

In 2016, we tried using git subtree instead of git submodules, but quickly found it difficult to use.
While git submodules is one of the worst examples of developer experience, subtree is even worse.

@alexey-milovidov alexey-milovidov merged commit 332df69 into master Jun 8, 2016
alexey-milovidov
alexey-milovidov reviewed Jun 8, 2016
View reviewed changes
Comment thread libs/libdaemon/src/BaseDaemon.cpp

@alexey-milovidov alexey-milovidov Jun 8, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Нет пробела.
Отображается так:

Received termination signal(Interrupt)

@alexey-milovidov

alexey-milovidov commented Jun 9, 2016

Copy link
Copy Markdown
Member

Потеряна функциональность быстрого убиения по повторному нажатию Ctrl+C (очень важно).

@PKartaviy

PKartaviy commented Jun 9, 2016

Copy link
Copy Markdown
Contributor Author

А такая функциональность была? в демонах только печаталось сообщение "Received second termination signal"

@PKartaviy

PKartaviy commented Jun 9, 2016

Copy link
Copy Markdown
Contributor Author

а если вызвать два раза рестарт, то тоже девятка? вообщем стоит обсудить

@alexey-milovidov

alexey-milovidov commented Jun 10, 2016

Copy link
Copy Markdown
Member

А такая функциональность была? в демонах только печаталось сообщение "Received second termination signal"

Это довольно забавно - такая функциональность была в clickhouse-server, но не было в других демонах Метрики. И сейчас мне её не хватает.

а если вызвать два раза рестарт, то тоже девятка? вообщем стоит обсудить

Даже не знаю, как лучше. Можно так же - это проще и понятнее, а можно отличить сигналы INT и TERM.

@PKartaviy

PKartaviy commented Jun 10, 2016

Copy link
Copy Markdown
Contributor Author

Засчет чего она достигалась. я не могу найти код, который бы это делал

@alexey-milovidov

alexey-milovidov commented Jun 10, 2016

Copy link
Copy Markdown
Member

@Nopius Nopius mentioned this pull request Dec 12, 2016
Closed
alexey-milovidov pushed a commit that referenced this pull request Jan 7, 2017
@zhkvia
Merge pull request #1 from yandex/master
f67f8df 
Update master
@jarwin123 jarwin123 mentioned this pull request Feb 15, 2017
Closed
@proller proller mentioned this pull request Oct 2, 2017
Closed
@slw slw mentioned this pull request Nov 9, 2017
Closed
@aavdonkin aavdonkin mentioned this pull request Dec 14, 2017
Merged
alexey-milovidov pushed a commit that referenced this pull request Feb 23, 2018
@chenxing-xc
Merge pull request #1 from yandex/master
92ab013 
rebase master
@huang--yijian huang--yijian mentioned this pull request Jul 23, 2018
Closed
zhang2014 pushed a commit to zhang2014/ClickHouse that referenced this pull request Aug 29, 2018
Merge branch 'feature/support_distributed_ddl_for_qingcloud' into 'Qi…
c18b73d 
…ngCloud'


CLICKHOUSE-1  Support distributed ddl for qingcloud

ClickHouse#1

See merge request !1
@EvgenyVinogradov EvgenyVinogradov mentioned this pull request Sep 12, 2018
Closed
@alex-zaitsev alex-zaitsev mentioned this pull request Sep 28, 2018
Closed
@den-crane den-crane mentioned this pull request Oct 2, 2018
Closed
@dijkstra33 dijkstra33 mentioned this pull request Oct 9, 2018
Closed
makimat referenced this pull request in softagram/ClickHouse Nov 21, 2018
@nicelulu
Merge pull request #1 from nicelulu/update_22
b8edb95 
Update 22   to click_update
This was referenced Jun 17, 2026
Merged
Open
Merged
Open
Merged
Open
Open
Merged
Merged
Open
Merged
Merged
This was referenced Jun 24, 2026
Open
Open
@groeneai groeneai mentioned this pull request Jun 25, 2026
Merged
This was referenced Jun 26, 2026
Open
Merged
Open
@groeneai groeneai mentioned this pull request Jun 29, 2026
Merged
@alexey-milovidov alexey-milovidov mentioned this pull request Jun 30, 2026
Open
1 task
@groeneai groeneai mentioned this pull request Jun 30, 2026
Merged
1 task
@alexey-milovidov alexey-milovidov mentioned this pull request Jun 30, 2026
Open
@clickhouse-gh clickhouse-gh Bot mentioned this pull request Jul 1, 2026
Open
This was referenced Jul 1, 2026
Merged
Open
This was referenced Jul 2, 2026
Merged
Open
@alexey-milovidov alexey-milovidov mentioned this pull request Jul 3, 2026
Open
1 task
This was referenced Jul 3, 2026
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexey-milovidov alexey-milovidov

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PKartaviy @alexey-milovidov @egatov