Bug fix. Account for multi_line=FALSE when facet rows/cols are missing. Closes #2341.#2373
Bug fix. Account for multi_line=FALSE when facet rows/cols are missing. Closes #2341.#2373trekonom wants to merge 3 commits into
Conversation
| row_txt <- if (!length(names(plot$facet$params$rows)) == 0) { | ||
| paste( | ||
| plot$facet$params$labeller( | ||
| lay[names(plot$facet$params$rows)] | ||
| ), | ||
| collapse = br() | ||
| ) | ||
| } else { | ||
| "" | ||
| } |
There was a problem hiding this comment.
Similar recommendation as https://github.com/plotly/plotly.R/pull/2373/files#r1742335996
There was a problem hiding this comment.
Thx for the review and the suggestions. Just committed both suggestions.
|
Thank you for the detailed explanation and contribution! This is looking very close to mergeable, I just had a couple stylistic suggestions |
|
Looking forward to this getting fixed, currently experiencing the issue with "expression(list())" |
|
@trekonom In addition to the bug you've fixed, there's also an issue where strip.position is not working in plotly. |
Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
Co-authored-by: Carson Sievert <cpsievert1@gmail.com>


This PR proposes a fix to account for
multi_line=FALSEin facet labeller functions, thereby closing #2341 .With the proposed fix, the reprex from #2341 renders correctly without the undesired, additional strip texts for the rows:
Created on 2024-08-24 with reprex v2.1.1