{{ message }}
Test format#1
Open
youknowone wants to merge 2 commits into
Open
Conversation
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
crates/vm/src/stdlib/ast/other.rs (1)
20-25: Consider formatting consistency in match arms.The match arms on lines 20-23 are reflowed across multiple lines while lines 24-25 remain on single lines. For consistency, consider applying the same formatting style to all arms, or verify this aligns with your project's rustfmt configuration.
Example consistent formatting (all on single lines):
.map(|flag| match flag { bytecode::ConversionFlag::None => Self::None, bytecode::ConversionFlag::Str => Self::Str, bytecode::ConversionFlag::Ascii => Self::Ascii, bytecode::ConversionFlag::Repr => Self::Repr, })
📜 Review details
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
crates/vm/src/stdlib/ast/other.rs(1 hunks)
🔇 Additional comments (1)
crates/vm/src/stdlib/ast/other.rs (1)
17-18: Approve formatting adjustment to.and_then()call.The closure formatting change improves readability by breaking the chain across lines. No functional impact.
youknowone
force-pushed
the
test-format
branch
from
bf1cd24 to
0c75c7c
Compare
youknowone
force-pushed
the
test-format
branch
2 times, most recently
from
71deb15 to
23acee9
Compare
youknowone
force-pushed
the
test-format
branch
from
23acee9 to
bb62766
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.