Update Configuration.php: Adding path to missing config file error message by ThomasLandauer · Pull Request #6939 · Codeception/Codeception · GitHub
Skip to content

Update Configuration.php: Adding path to missing config file error message#6939

Open
ThomasLandauer wants to merge 1 commit into
Codeception:mainfrom
ThomasLandauer:patch-15
Open

Update Configuration.php: Adding path to missing config file error message#6939
ThomasLandauer wants to merge 1 commit into
Codeception:mainfrom
ThomasLandauer:patch-15

Conversation

@ThomasLandauer

Copy link
Copy Markdown
Member

No description provided.

Comment on lines 146 to +148

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThomasLandauer The exception is thrown if neither $configFile nor $configDistFile were found. Should this be reflected in the the message, f.e. by using Configuration files $configFile and $configDistFile could not be found?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot, which config files are we talking about here? Probably codeception.yml or Functional.suite.yml? I've never seen a .yml,dist file of those (where would they come from?), so I figured that's not no important.
Besides, IMO, the idea of .dist is to contain factory default values, so if you don't have one, the solution is not to create one, but rather to create your own *.yml file - isn't it?
And lastly, I didn't want to cover all (exotic) use cases, but just point the user to the right direction (i.e. which file).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants