chore: Clean up sendgrid.py by Aman-am · Pull Request #844 · sendgrid/sendgrid-python · GitHub
Skip to content

chore: Clean up sendgrid.py#844

Merged
childish-sambino merged 2 commits into
sendgrid:masterfrom
Aman-am:patch-1
Feb 26, 2020
Merged

chore: Clean up sendgrid.py#844
childish-sambino merged 2 commits into
sendgrid:masterfrom
Aman-am:patch-1

Conversation

@Aman-am

@Aman-am Aman-am commented Oct 9, 2019

Copy link
Copy Markdown
Contributor

Minor Change

Fixes #X

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them
  • I updated my branch with the master branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

If you have questions, please send an email to Twilio SendGrid, or file a GitHub Issue in this repository.

Minor Change
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 9, 2019
@codecov

codecov Bot commented Oct 9, 2019

Copy link
Copy Markdown

Comment thread sendgrid/sendgrid.py
import python_http_client


class SendGridAPIClient(object):

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you'll use a good linter like python-black. It'll automatically handle all these things and also the two-line gap before python classes are best practices. You may have a look at other files too.

@childish-sambino childish-sambino changed the title Update Sendgrid.py chore: Clean up sendgrid.py Feb 26, 2020
@childish-sambino childish-sambino merged commit 83e25d3 into sendgrid:master Feb 26, 2020
@thinkingserious

Copy link
Copy Markdown
Contributor

Hello @Aman-am,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@Aman-am

Aman-am commented Feb 27, 2020

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: code review request requesting a community code review or review from Twilio

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants