{{ message }}
feat: Add equality to Email#739
Merged
Merged
Conversation
Email objects are defined as equal iff they have the same email and the same name. This is useful for unit tests where we want to verify that the Email objects generated are as expected.
thinkingserious
added
the
status: code review request
Codecov Report
@@ Coverage Diff @@
## master #739 +/- ##
==========================================
+ Coverage 82.41% 82.48% +0.06%
==========================================
Files 70 70
Lines 2303 2312 +9
Branches 338 340 +2
==========================================
+ Hits 1898 1907 +9
Misses 206 206
Partials 199 199 Continue to review full report at Codecov.
|
childish-sambino
approved these changes
Mar 6, 2020
|
If, I may point out, this makes Email objects unhashable, which is inconvenient in some cases. For example getting rid of duplicates in a list of cc's. I suppose this should be considered a regression and should be fixed up? |
Contributor
|
@eprykhodko Ack, taking a look. This was definitely not the intent. |
Contributor
childish-sambino
pushed a commit
that referenced
this pull request
Jun 11, 2020
This reverts commit b2ca1f4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Short description of what this PR does:
Email objects are defined as equal iff they have the same email and the same name.
This is useful for unit tests where we want to verify that the Email objects generated are as expected.