docs: Fix grammatical errors by vinayak42 · Pull Request #706 · sendgrid/sendgrid-python · GitHub
Skip to content

docs: Fix grammatical errors#706

Merged
childish-sambino merged 2 commits into
sendgrid:masterfrom
vinayak42:patch-3
Mar 6, 2020
Merged

docs: Fix grammatical errors#706
childish-sambino merged 2 commits into
sendgrid:masterfrom
vinayak42:patch-3

Conversation

@vinayak42

Copy link
Copy Markdown
Contributor

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Fix grammatical errors in comments

If you have questions, please send an email to SendGrid, or file a GitHub Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 23, 2018
@codecov

codecov Bot commented Oct 23, 2018

Copy link
Copy Markdown

@misterdorm misterdorm added status: work in progress Twilio or the community is in the process of implementing difficulty: easy fix is easy in difficulty and removed status: code review request requesting a community code review or review from Twilio labels Oct 30, 2018

@misterdorm misterdorm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please rebase this against the v4 branch? Thanks!

@thinkingserious thinkingserious added status: waiting for feedback waiting for feedback from the submitter type: docs update documentation change not affecting the code status: hacktoberfest approved and removed status: work in progress Twilio or the community is in the process of implementing labels Oct 31, 2018
@thinkingserious

Copy link
Copy Markdown
Contributor

Hello @vinayak42,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@vinayak42

Copy link
Copy Markdown
Contributor Author

@thinkingserious @misterdorm Apologies for the inconvenience. I am having some issues about rebasing this to v4. Could you trace the exact steps/commands to do the same in GitHub?

@misterdorm

Copy link
Copy Markdown
Contributor

@vinayak42 It's probably easiest to start with a new branch, branched from v4, and then merge/apply your commits onto that branch. And then force push to this PR.

@vinayak42

Copy link
Copy Markdown
Contributor Author

@misterdorm Thanks for the info.
On a side note, I noticed that my username no longer appears on the SendGrid Leaderboard, as it used to, a few days ago. Kindly look into the matter. Thanks

@misterdorm

Copy link
Copy Markdown
Contributor

I know that they are still tabulating the final scores, etc., so there may be some inaccuracies on that page.

@thinkingserious

Copy link
Copy Markdown
Contributor

@childish-sambino childish-sambino changed the title Fix grammatical errors docs: Fix grammatical errors Mar 6, 2020
@childish-sambino childish-sambino merged commit 499c5f1 into sendgrid:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: easy fix is easy in difficulty status: waiting for feedback waiting for feedback from the submitter type: docs update documentation change not affecting the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants