Allow users to disable MultiSourceReader trackData through ParserOptions by AntaresS · Pull Request #3062 · graphql-java/graphql-java · GitHub
Skip to content

Allow users to disable MultiSourceReader trackData through ParserOptions#3062

Merged
dondonz merged 1 commit into
graphql-java:masterfrom
AntaresS:add-trackData-to-ParserOptions
Jan 21, 2023
Merged

Allow users to disable MultiSourceReader trackData through ParserOptions#3062
dondonz merged 1 commit into
graphql-java:masterfrom
AntaresS:add-trackData-to-ParserOptions

Conversation

@AntaresS

@AntaresS AntaresS commented Dec 20, 2022

Copy link
Copy Markdown

PR for #3061

This change adds a new option into ParserOptions which is configurable by users so that we can pass it down to the underlying MultiSourceReader to control whether to enable trackData or not.

@bbakerman bbakerman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement.

@bbakerman bbakerman added this to the 21.0 milestone Dec 28, 2022
@AntaresS

AntaresS commented Jan 12, 2023

Copy link
Copy Markdown
Author

@dondonz

dondonz commented Jan 12, 2023

Copy link
Copy Markdown
Member

@AntaresS We'll consider doing another v20 release when we have a few more PRs to release in a batch

@AntaresS

Copy link
Copy Markdown
Author

@AntaresS We'll consider doing another v20 release when we have a few more PRs to release in a batch

Great. Thanks!

@AntaresS

Copy link
Copy Markdown
Author

@dondonz @bbakerman Can we get an ETA on when a patch release will be made? Thanks.

@dondonz

dondonz commented Jan 21, 2023

Copy link
Copy Markdown
Member

Hi @AntaresS thanks for asking. We're in the process of formalising a release schedule. When it is finalised we will announce it publicly. Do bear with me as some of the team is on holiday.

@bbakerman

Copy link
Copy Markdown
Member

@andimarek andimarek modified the milestones: 21.0, April 2023 Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants