{{ message }}
temurin-jre: correct extract_dir in autoupdate#602
Closed
B67687 wants to merge 6 commits into
Closed
Conversation
Contributor
|
All changes look good. Wait for review from human collaborators. temurin-jre
|
Contributor
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with temurin-jre
temurin-lts-jre
|
Contributor
|
All changes look good. Wait for review from human collaborators. temurin-jre
temurin-lts-jre
|
B67687
changed the title
B67687
changed the title
Contributor
|
All changes look good. Wait for review from human collaborators. temurin-jre
temurin-lts-jre
|
The suffix IS correct for Temurin JRE ZIPs. All specific-version JRE manifests (temurin26-jre.json, temurin25-jre.json, etc.) consistently use the suffix. The PR's removal of it was based on an incorrect assumption about the ZIP's extracted directory name.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #552
Summary
Fixes the extraction directory mismatch bug that causes temurin-jre and temurin-lts-jre updates to fail.
Problem
The autoupdate formula uses
$matchTag-jrewhich adds a-jresuffix to the expected extraction directory. However, the actual extracted directory from the Temurin JRE ZIP files is justjdk-{tag}WITHOUT the-jresuffix.This caused issue #552 where updating temurin-jre from 24.0.1-9 to 24.0.2-12 failed with "Could not find jdk-24.0.2+12-jre".
Fix
$matchTag-jreto$matchTag-jresuffix to base tag; also updated to latest LTS version 25.0.3-9Validation
All checks pass in both manifests.